Re: RFR: 8277957: Add test group for IPv6 exclusive testing [v2]

2021-12-06 Thread Mark Sheppard
On Fri, 3 Dec 2021 20:26:46 GMT, Ivan Šipka wrote: >> Adding test group for IPv6 exclusive testing. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > added comment for adding the ipv6_only testgroup Marked as reviewed by mshe

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Aleksey Shipilev
On Sun, 5 Dec 2021 16:44:05 GMT, Alan Bateman wrote: > There are several thread safety issues in java.net.ServerSocket, issues that > go back to at least JDK 1.4. > > The issue of most concern is async close of a ServerSocket that is initially > created unbound and where close may be called at

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Alan Bateman
On Mon, 6 Dec 2021 11:29:20 GMT, Aleksey Shipilev wrote: >> There are several thread safety issues in java.net.ServerSocket, issues that >> go back to at least JDK 1.4. >> >> The issue of most concern is async close of a ServerSocket that is initially >> created unbound and where close may be

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Alan Bateman
On Mon, 6 Dec 2021 11:30:12 GMT, Aleksey Shipilev wrote: >> There are several thread safety issues in java.net.ServerSocket, issues that >> go back to at least JDK 1.4. >> >> The issue of most concern is async close of a ServerSocket that is initially >> created unbound and where close may be

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Aleksey Shipilev
On Mon, 6 Dec 2021 11:40:46 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/net/ServerSocket.java line 90: >> >>> 88: private volatile boolean created; // impl.create(boolean) called >>> 89: private volatile boolean bound; >>> 90: private volatile boolean closed; >> >

Re: RFR: 8277957: Add test group for IPv6 exclusive testing [v2]

2021-12-06 Thread Dermot Boyle
On Fri, 3 Dec 2021 20:26:46 GMT, Ivan Šipka wrote: >> Adding test group for IPv6 exclusive testing. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > added comment for adding the ipv6_only testgroup Marked as reviewed by derm

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Alan Bateman
On Mon, 6 Dec 2021 11:28:16 GMT, Aleksey Shipilev wrote: >> There are several thread safety issues in java.net.ServerSocket, issues that >> go back to at least JDK 1.4. >> >> The issue of most concern is async close of a ServerSocket that is initially >> created unbound and where close may be

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Florian Weimer
On Sun, 5 Dec 2021 16:44:05 GMT, Alan Bateman wrote: > There are several thread safety issues in java.net.ServerSocket, issues that > go back to at least JDK 1.4. > > The issue of most concern is async close of a ServerSocket that is initially > created unbound and where close may be called at

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Daniel Fuchs
On Sun, 5 Dec 2021 16:44:05 GMT, Alan Bateman wrote: > There are several thread safety issues in java.net.ServerSocket, issues that > go back to at least JDK 1.4. > > The issue of most concern is async close of a ServerSocket that is initially > created unbound and where close may be called at

Re: RFR: 8278270: ServerSocket is not thread safe

2021-12-06 Thread Alan Bateman
On Mon, 6 Dec 2021 13:39:11 GMT, Florian Weimer wrote: > To what extent is `ServerSocket` required to be thread-safe? I don't think > it's part of the specification. A ServerSocket is required by the spec to be asynchronously closable, that is the motivation for the changes here. java.net.Soc

RFR: 8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer

2021-12-06 Thread Aleksei Efimov
The following fix clarifies spec for `InetAddressResolverProvider.get(Configuration)` method to state that an error or exception thrown by this method will be propagated to to the caller of the method that triggered the lookup operation. The `InetAddressResolverProvider#system-wide-resolver`

Re: RFR: 8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer

2021-12-06 Thread Alan Bateman
On Mon, 6 Dec 2021 15:55:52 GMT, Aleksei Efimov wrote: > The following fix clarifies spec for > `InetAddressResolverProvider.get(Configuration)` method to state that an > error or exception thrown by this method will be propagated to to the caller > of the method that triggered the lookup oper

Re: RFR: 8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer

2021-12-06 Thread Daniel Fuchs
On Mon, 6 Dec 2021 15:55:52 GMT, Aleksei Efimov wrote: > The following fix clarifies spec for > `InetAddressResolverProvider.get(Configuration)` method to state that an > error or exception thrown by this method will be propagated to to the caller > of the method that triggered the lookup oper

Re: RFR: 8278263: Remove redundant synchronized from URLStreamHandler.openConnection methods

2021-12-06 Thread Daniel Fuchs
On Fri, 12 Nov 2021 19:35:10 GMT, Andrey Turbanov wrote: > All this Handler's are stateless and there is nothing to protect via > synchronization. Seems reasonable but I'd prefer if this were being pushed in 19 after RDP1. - PR: https://git.openjdk.java.net/jdk/pull/6373

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-06 Thread Phil Race
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request inc

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-06 Thread Phil Race
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote: >> Here are the code changes for the "Deprecate finalizers in the standard Java >> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code >> review. >> >> This change makes the indicated deprecations, and updates the API

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v4]

2021-12-06 Thread Brent Christian
> Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec for > JEP 421. It also updates the relevant @SuppressWarn

Integrated: 8277957: Add test group for IPv6 exclusive testing

2021-12-06 Thread Ivan Šipka
On Mon, 29 Nov 2021 20:04:13 GMT, Ivan Šipka wrote: > Adding test group for IPv6 exclusive testing. This pull request has now been integrated. Changeset: 2ff12966 Author:Ivan Šipka Committer: Mark Sheppard URL: https://git.openjdk.java.net/jdk/commit/2ff12966a345eaa1c16ed73165b3eb2