On Thu, 2 Dec 2021 15:11:08 GMT, Julia Boes wrote:
> This doc-only change amends the method-level documentation of
> SimpleFileServer#createFileServer() to specify the state of the returned
> server.
This pull request has now been integrated.
Changeset: 53df9ffb
Author:Julia Boes
URL:
Hi Jaikiran,
A couple of remarks:
> However, in this specific case the Builder is expected
> to be created using the static java.net.http.HTTPClient.newBuilder()
> method and that implementation always returns an internal implementation
> of the Builder interface. That effectively means that the
Hello Daniel,
On 03/12/21 5:59 pm, Daniel Fuchs wrote:
Hi Jaikiran,
A couple of remarks:
> However, in this specific case the Builder is expected
> to be created using the static java.net.http.HTTPClient.newBuilder()
> method and that implementation always returns an internal
implementation
Yes, I agree with this. It's a niche use case which should be made clear
in the docs.
The new method should have a default implementation.
I think I prefer also to use a SocketAddress in case there is some
future need to also
specify the local port. The InetSocketAddress constructors allow a
> Adding test group for IPv6 exclusive testing.
Ivan Šipka has updated the pull request incrementally with one additional
commit since the last revision:
added comment for adding the ipv6_only testgroup
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6600/files
- new
On Fri, 3 Dec 2021 07:30:43 GMT, ANUPAM DEV wrote:
> The documentation for following methods used equals() for object equality:
>
> sun.awt.util.IdentityLinkedList#contains
> sun.awt.util.IdentityArrayList#contains
> sun.awt.util.IdentityArrayList#indexOf
> sun.awt.util.IdentityArrayList#lastInd
On Fri, 3 Dec 2021 07:30:43 GMT, ANUPAM DEV wrote:
> The documentation for following methods used equals() for object equality:
>
> sun.awt.util.IdentityLinkedList#contains
> sun.awt.util.IdentityArrayList#contains
> sun.awt.util.IdentityArrayList#indexOf
> sun.awt.util.IdentityArrayList#lastInd
