Should SimpleFileServer#createFileServer() mention that the returned server isn't started?

2021-12-02 Thread Jaikiran Pai
Right now, the com.sun.net.httpserver.SimpleFileServer#createFileServer states this: " * Creates a file server the serves files from a given path. * * The server is configured with an initial context that maps the * URI {@code path} to a file handler. The file handler is

Re: Should SimpleFileServer#createFileServer() mention that the returned server isn't started?

2021-12-02 Thread Julia Boes
Hi Jaikiran, I agree, a sentence like "The returned server is not started." should be added, similar to the API doc of the new HttpServer::create. I filed an issue for it: https://bugs.openjdk.java.net/browse/JDK-8278154 While here, I'll fix the typo in the first line, too. Regards, Julia

RFR: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started

2021-12-02 Thread Julia Boes
This doc-only change amends the method-level documentation of SimpleFileServer#createFileServer() to specify the state of the returned server. - Commit messages: - initial commit Changes: https://git.openjdk.java.net/jdk/pull/6674/files Webrev: https://webrevs.openjdk.java.net/?re

Re: RFR: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started

2021-12-02 Thread Jaikiran Pai
On Thu, 2 Dec 2021 15:11:08 GMT, Julia Boes wrote: > This doc-only change amends the method-level documentation of > SimpleFileServer#createFileServer() to specify the state of the returned > server. Hello Julia, Thank you for this quick change. I'm not a Reviewer, but this looks good to me.

Re: RFR: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started

2021-12-02 Thread Daniel Fuchs
On Thu, 2 Dec 2021 15:11:08 GMT, Julia Boes wrote: > This doc-only change amends the method-level documentation of > SimpleFileServer#createFileServer() to specify the state of the returned > server. Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/

Re: RFR: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started

2021-12-02 Thread Julia Boes
On Thu, 2 Dec 2021 15:11:08 GMT, Julia Boes wrote: > This doc-only change amends the method-level documentation of > SimpleFileServer#createFileServer() to specify the state of the returned > server. CSR: https://bugs.openjdk.java.net/browse/JDK-8278159 - PR: https://git.openjdk.

RFR: JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java

2021-12-02 Thread Tim Prinzing
JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java - Commit messages: - Merge branch 'master' into JDK-8276681 - Fix missing '@' in javadoc for JDK-8276681 Changes: https://git.openjdk.java.net/jdk/pull/6486/files Webrev: https

Re: RFR: JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java

2021-12-02 Thread Lance Andersen
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote: > JDK-8276681: Malformed Javadoc inline tags in JDK source > jdk/internal/net/http/ResponseSubscribers.java Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6486

Integrated: JDK-8276681: Additional malformed Javadoc inline tags in JDK source

2021-12-02 Thread Tim Prinzing
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote: > JDK-8276681: Additional malformed Javadoc inline tags in JDK source This pull request has now been integrated. Changeset: b8ac0d20 Author:Tim Prinzing Committer: Lance Andersen URL: https://git.openjdk.java.net/jdk/commit/b8ac

Re: RFR: JDK-8276681: Additional malformed Javadoc inline tags in JDK source [v2]

2021-12-02 Thread Tim Prinzing
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional comm

Proposal - 8209137: Add ability to bind to specific local address to HTTP client

2021-12-02 Thread Jaikiran Pai
I've been working on adding support for the enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8209137. As noted in that issue, right now the java.net.http.HTTPClient doesn't have a way to allow applications to specify which local address to use while connecting to target hosts durin

RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

2021-12-02 Thread ANUPAM DEV
Updated sun.awt.util.IdentityArrayList and sun.awt.util.IdentityLinkedList - Commit messages: - Javadoc incorrect for IdentityArrayList, IdentityLinkedList - Merge pull request #1 from anupamdev20/JDK-8255675 - 8255675: Typo in java.net.HttpURLConnection Changes: https://git.openj

Withdrawn: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

2021-12-02 Thread ANUPAM DEV
On Fri, 3 Dec 2021 06:33:45 GMT, ANUPAM DEV wrote: > The following methods were having improper improper as they mentioned > 'equals()' while comparing two objects. The comments have been changed to > reflect the comparison of two objects using == operator. > > sun.awt.util.IdentityLinkedList#

RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

2021-12-02 Thread ANUPAM DEV
The documentation for following methods used equals() for object equality: sun.awt.util.IdentityLinkedList#contains sun.awt.util.IdentityArrayList#contains sun.awt.util.IdentityArrayList#indexOf sun.awt.util.IdentityArrayList#lastIndexOf sun.awt.util.IdentityArrayList#remove(java.lang.Object) I h