On Thu, 11 Nov 2021 12:05:49 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which implements the enhancement
> noted in https://bugs.openjdk.java.net/browse/JDK-8276559?
>
> The commit in this PR introduces a new `HEAD()` method on the
> `HttpRequest.Builder` interface.
On Fri, 12 Nov 2021 04:30:31 GMT, Jaikiran Pai wrote:
> Is it intentional that this new manual test and the existing tests in
> "simpleserver" don't have a `@bug` id noted on their test definition?
I don't think the `@bug` tag is necessary for tests that are added as part of a
JEP, but I added
> This change corrects the server configuration in `testBindAllInterfaces` to
> specify the port. Additionally, a manual test is added for the case where the
> port is not specified and the server uses the default port 8000, which might
> already be in use by another test. To avoid this scenario
On Thu, 11 Nov 2021 14:58:45 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they ar
On Fri, 12 Nov 2021 09:54:58 GMT, Julia Boes wrote:
>> This change corrects the server configuration in `testBindAllInterfaces` to
>> specify the port. Additionally, a manual test is added for the case where
>> the port is not specified and the server uses the default port 8000, which
>> might
On Thu, 11 Nov 2021 12:05:49 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which implements the enhancement
> noted in https://bugs.openjdk.java.net/browse/JDK-8276559?
>
> The commit in this PR introduces a new `HEAD()` method on the
> `HttpRequest.Builder` interface.
On Thu, 11 Nov 2021 12:05:49 GMT, Jaikiran Pai wrote:
> P.S: Slightly unrelated question - is it intentional that the `Builder`
> interface specifies the visibility modifiers on the interface methods. For
> example: `public abstract Builder timeout(Duration duration);`, `public
> Builder heade
On Fri, 12 Nov 2021 10:54:20 GMT, Daniel Fuchs wrote:
> > P.S: Slightly unrelated question - is it intentional that the `Builder`
> > interface specifies the visibility modifiers on the interface methods. For
> > example: `public abstract Builder timeout(Duration duration);`, `public
> > Build
> Can I please get a review for this change which implements the enhancement
> noted in https://bugs.openjdk.java.net/browse/JDK-8276559?
>
> The commit in this PR introduces a new `HEAD()` method on the
> `HttpRequest.Builder` interface. Given that this is a public interface on a
> public cla
On Fri, 12 Nov 2021 10:15:29 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Implement Daniel's review suggestion - use a different URI for HEAD()
>> request in HttpRequestNewBuilderTest
>> -
On Fri, 12 Nov 2021 10:27:50 GMT, Daniel Fuchs wrote:
> Maybe `test/jdk/java/net/httpclient/HeadTest.java` could acquire a new
> dedicated method where `HttpRequest.Builder.HEAD()` is used. The test
> currently tests `method("HEAD", BodyPublishers.noBody());`
I've updated the `HeadTest` to inc
> There are some regression tests depending on sun.net.www.MessageHeader, the
> internal API dependency should be removed. Some of other internal API
> dependancies are removed in following issues :
> JDK-8273142
> JDK-8268464
> JDK-8268133
Mahendra Chhipa has updated the pull request incrementa
On Thu, 11 Nov 2021 17:08:37 GMT, Julia Boes wrote:
> This change corrects the server configuration in `testBindAllInterfaces` to
> specify the port. Additionally, a manual test is added for the case where the
> port is not specified and the server uses the default port 8000, which might
> alr
On Thu, 11 Nov 2021 14:58:45 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they ar
On Fri, 12 Nov 2021 11:22:19 GMT, Jaikiran Pai wrote:
> > > P.S: Slightly unrelated question - is it intentional that the `Builder`
> > > interface specifies the visibility modifiers on the interface methods.
> > > For example: `public abstract Builder timeout(Duration duration);`,
> > > `publ
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
This pull request has now been integrated.
Change
16 matches
Mail list logo
