On Thu, 14 Oct 2021 17:29:16 GMT, Daniel Jeliński wrote:
> Per Java documentation,
> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
> [..] indicates serious problems that a reasonable application should not try
> to catch". Failure to
Hi,
Please review my fix for JDK-8274779 which changes how HttpClient and
HttpsClient checks for equality when comparing request methods.
When `HttpURLConnection.setRequestMethod` is passed `new String("POST")` rather
than the "POST" String literal, the old behaviour resulted in broken
HttpC
On Fri, 15 Oct 2021 08:49:20 GMT, Evan Whelan wrote:
> Hi,
>
> Please review my fix for JDK-8274779 which changes how HttpClient and
> HttpsClient checks for equality when comparing request methods.
>
> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
> rather than t
On Fri, 15 Oct 2021 03:30:49 GMT, Jaikiran Pai wrote:
>> Per Java documentation,
>> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30)
>> [..] indicates serious problems that a reasonable application should not
>> try to catch". Failure to
On Fri, 15 Oct 2021 10:01:19 GMT, Daniel Jeliński wrote:
> It happens occasionally, as evidenced by JDK-8217298, JDK-8046500 (fixed),
> JDK-8165665, JDK-8066931, JDK-8057900, JDK-8065559(closed), JDK-8040229,
> JDK-8065078(fixed), JDK-8068597(fixed), numerous reports on Google (search
> for "e
On Fri, 15 Oct 2021 11:22:23 GMT, Daniel Fuchs wrote:
> It happens occasionally, as evidenced by JDK-8217298, JDK-8046500 (fixed),
> JDK-8165665, JDK-8066931, JDK-8057900, JDK-8065559(closed), JDK-8040229,
> JDK-8065078(fixed), JDK-8068597(fixed), numerous reports on Google (search
> for "erro
> Hi,
>
> Please review my fix for JDK-8274779 which changes how HttpClient and
> HttpsClient checks for equality when comparing request methods.
>
> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
> rather than the "POST" String literal, the old behaviour resulted in
> There are some regression tests depending on sun.net.www.MessageHeader, the
> internal API dependency should be removed. Some of other internal API
> dependancies are removed in following issues :
> JDK-8273142
> JDK-8268464
> JDK-8268133
Mahendra Chhipa has updated the pull request incrementa
On Fri, 15 Oct 2021 12:38:14 GMT, Mahendra Chhipa wrote:
>> There are some regression tests depending on sun.net.www.MessageHeader, the
>> internal API dependency should be removed. Some of other internal API
>> dependancies are removed in following issues :
>> JDK-8273142
>> JDK-8268464
>> JDK
On Fri, 15 Oct 2021 12:38:14 GMT, Mahendra Chhipa wrote:
>> There are some regression tests depending on sun.net.www.MessageHeader, the
>> internal API dependency should be removed. Some of other internal API
>> dependancies are removed in following issues :
>> JDK-8273142
>> JDK-8268464
>> JDK
On Fri, 15 Oct 2021 09:36:06 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Extracted both connectTimeouts to variables and added copyright header to
>> accessor
>> - Removed reflection in fav
> Hi,
>
> Please review my fix for JDK-8274779 which changes how HttpClient and
> HttpsClient checks for equality when comparing request methods.
>
> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
> rather than the "POST" String literal, the old behaviour resulted in
On Fri, 15 Oct 2021 09:38:50 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Extracted both connectTimeouts to variables and added copyright header to
>> accessor
>> - Removed reflection in fav
On Fri, 15 Oct 2021 14:47:18 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Fri, 15 Oct 2021 14:47:18 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Fri, 15 Oct 2021 14:47:18 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Fri, 15 Oct 2021 11:22:23 GMT, Daniel Fuchs wrote:
> we need to examine each of these on a case-by-case basis
Makes sense.
1. `MultiByteToWideChar` case: we can change this to `InternalError`, as it's
not supposed to happen and apparently not happening
2.
[GetIfTable](https://docs.microsof
On Tue, 12 Oct 2021 15:43:24 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
19 matches
Mail list logo
