Re: RFR: 8270290: NTLM authentication fails if HEAD request is used [v2]

2021-09-30 Thread Alex Kasko
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote: >> When HEAD request is used with a proxy (or a server) that requires NTLM, >> authentication fails when server returns large (8kb+) body along with >> NTLMSSP_CHALLENGE response. >> >> Proposed fix is to check for ongoing NTLM auth in `reset

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-30 Thread Daniel Fuchs
On Wed, 29 Sep 2021 19:24:36 GMT, Michael McMahon wrote: >> Hi @Michael-Mc-Mahon , In my understanding purpose of this block is to >> return a file with no contents.(Empty file). > > I think it would be simpler to replace lines 101-103 just with `trans.close()` Strictly speaking to preserve the

Re: RFR: 8270290: NTLM authentication fails if HEAD request is used [v2]

2021-09-30 Thread Daniel Fuchs
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote: >> When HEAD request is used with a proxy (or a server) that requires NTLM, >> authentication fails when server returns large (8kb+) body along with >> NTLMSSP_CHALLENGE response. >> >> Proposed fix is to check for ongoing NTLM auth in `reset

Re: RFR: 8270290: NTLM authentication fails if HEAD request is used [v2]

2021-09-30 Thread Daniel Fuchs
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote: >> When HEAD request is used with a proxy (or a server) that requires NTLM, >> authentication fails when server returns large (8kb+) body along with >> NTLMSSP_CHALLENGE response. >> >> Proposed fix is to check for ongoing NTLM auth in `reset

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v3]

2021-09-30 Thread Mahendra Chhipa
> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed > from following tests: > open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java > open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java > open/test/jdk/sun/net/www/protocol/http/RelativeRedirect.j

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-30 Thread Michael McMahon
On Thu, 30 Sep 2021 09:05:41 GMT, Daniel Fuchs wrote: >> I think it would be simpler to replace lines 101-103 just with >> `trans.close()` > > Strictly speaking to preserve the current behavior - that would be > `trans.getResponseBody().close();` isn't it? HttpExchange.close() calls the close

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v3]

2021-09-30 Thread Michael McMahon
On Thu, 30 Sep 2021 09:38:17 GMT, Mahendra Chhipa wrote: >> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed >> from following tests: >> open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java >> open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.j

RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Ao Qi
When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java timed out on slow machines. The parameter of setSoTimeout in the test should be set larger. - Commit messages: - 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Changes: https://git.o

Integrated: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests

2021-09-30 Thread Mahendra Chhipa
On Thu, 2 Sep 2021 17:30:02 GMT, Mahendra Chhipa wrote: > Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed > from following tests: > open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java > open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java >

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Jie Fu
On Thu, 30 Sep 2021 11:14:18 GMT, Ao Qi wrote: > When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java > timed out on slow machines. The parameter of setSoTimeout in the test should > be set larger. The copyright year? - PR: https://git.openjdk.java.net/jdk/

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines [v2]

2021-09-30 Thread Ao Qi
> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java > timed out on slow machines. The parameter of setSoTimeout in the test should > be set larger. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: update copyright

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines [v2]

2021-09-30 Thread Jie Fu
On Thu, 30 Sep 2021 11:46:45 GMT, Ao Qi wrote: >> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java >> timed out on slow machines. The parameter of setSoTimeout in the test should >> be set larger. > > Ao Qi has updated the pull request incrementally with one additiona

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Ao Qi
On Thu, 30 Sep 2021 11:37:41 GMT, Jie Fu wrote: >> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java >> timed out on slow machines. The parameter of setSoTimeout in the test should >> be set larger. > > The copyright year? Updated. Thanks, @DamonFool :) -

Re: RFR: 8270290: NTLM authentication fails if HEAD request is used [v2]

2021-09-30 Thread Daniel Fuchs
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote: >> When HEAD request is used with a proxy (or a server) that requires NTLM, >> authentication fails when server returns large (8kb+) body along with >> NTLMSSP_CHALLENGE response. >> >> Proposed fix is to check for ongoing NTLM auth in `reset

Re: RFR: 8270290: NTLM authentication fails if HEAD request is used [v2]

2021-09-30 Thread Michael McMahon
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote: >> When HEAD request is used with a proxy (or a server) that requires NTLM, >> authentication fails when server returns large (8kb+) body along with >> NTLMSSP_CHALLENGE response. >> >> Proposed fix is to check for ongoing NTLM auth in `reset

Re: RFR: 8270290: NTLM authentication fails if HEAD request is used [v2]

2021-09-30 Thread Alex Kasko
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote: >> When HEAD request is used with a proxy (or a server) that requires NTLM, >> authentication fails when server returns large (8kb+) body along with >> NTLMSSP_CHALLENGE response. >> >> Proposed fix is to check for ongoing NTLM auth in `reset

Integrated: 8270290: NTLM authentication fails if HEAD request is used

2021-09-30 Thread Alex Kasko
On Mon, 12 Jul 2021 10:34:54 GMT, Alex Kasko wrote: > When HEAD request is used with a proxy (or a server) that requires NTLM, > authentication fails when server returns large (8kb+) body along with > NTLMSSP_CHALLENGE response. > > Proposed fix is to check for ongoing NTLM auth in `reset()` a

Re: RFR: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress

2021-09-30 Thread Daniel Fuchs
On Wed, 29 Sep 2021 15:41:06 GMT, Aleksei Efimov wrote: > The following fix proposes to remove usages of `"impl.prefix"` JDK system > property from the `java.net.InetAddress` class. > This system property is used to locate concrete implementations of the > package private "java.net.InetAddress

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines [v2]

2021-09-30 Thread Daniel Fuchs
On Thu, 30 Sep 2021 11:50:12 GMT, Ao Qi wrote: >> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java >> timed out on slow machines. The parameter of setSoTimeout in the test should >> be set larger. > > Ao Qi has updated the pull request incrementally with one additiona

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Ao Qi
On Thu, 30 Sep 2021 11:37:41 GMT, Jie Fu wrote: >> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java >> timed out on slow machines. The parameter of setSoTimeout in the test should >> be set larger. > > The copyright year? Thanks, @DamonFool @dfuch ! - P