Re: RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Daniel Fuchs
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Integrated: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-09-24 Thread Masanori Yano
On Fri, 27 Aug 2021 08:37:46 GMT, Masanori Yano wrote: > Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) This

Re: RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Weijun Wang
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Re: RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Daniel Fuchs
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Integrated: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Andrey Turbanov
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read