Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Chris Hegarty
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 15:23:33 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch 'origin/simples

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch 'origin/simpleserv

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v4]

2021-09-22 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request incrementally with

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-22 Thread Masanori Yano
On Thu, 16 Sep 2021 10:33:09 GMT, Daniel Fuchs wrote: >> I pushed a fix to run the test in othervm mode. Please test again. > > Meanwhile I did some experiment and was puzzled by the fact that the new test > still failed intermittently - while the corresponding > SctpMultiChannel/CloseDescripto

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 17:16:08 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch 'origin/simples

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Julia Boes
> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is th

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Julia Boes
On Fri, 17 Sep 2021 14:11:38 GMT, Julia Boes wrote: > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > This being said, I want to make sure we're taking the right decision here so > let me se

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Daniel Fuchs
On Wed, 22 Sep 2021 15:26:33 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-22 Thread Mahendra Chhipa
> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed > from following tests: > open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java > open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java > open/test/jdk/sun/net/www/protocol/http/RelativeRedirect.j

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Jaikiran Pai
On Wed, 22 Sep 2021 15:20:21 GMT, Julia Boes wrote: > > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > > This being said, I want to make sure we're taking the right decision here > > so l