On Tue, 14 Sep 2021 09:46:21 GMT, Julia Boes wrote:
> This change adds some common types to the content-type.properties files,
> notably .js, .css, and .jar, as well as some others.
>
> The duplicated entry for .zip is removed from the Windows properties file.
This pull request has now been i
Pass "cause" exception as constructor parameter is shorter and easier to read.
-
Commit messages:
- [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.base
module
Changes: https://git.openjdk.java.net/jdk/pull/5551/files
Webrev: https://webrevs.openjdk.java.net/?re
On Thu, 16 Sep 2021 19:03:26 GMT, Andrey Turbanov
wrote:
> Pass "cause" exception as constructor parameter is shorter and easier to read.
This will need to be thoroughly tested to make sure there were no implicit
dependencies on now-removed happens-before edges (`initCause` is synchronized).
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method is run when the above command is
> executed. This is th
On Thu, 16 Sep 2021 19:03:26 GMT, Andrey Turbanov
wrote:
> Pass "cause" exception as constructor parameter is shorter and easier to read.
Looks fine. Thanks.
-
Marked as reviewed by weijun (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5551
On Mon, 20 Sep 2021 16:16:10 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java
>> line 340:
>>
>>> 338: }
>>> 339: }
>>> 340: return false;
>>
>> This will start checking from the root of
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:59:18 GMT, Hannes Wallnöfer wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge remote-tracking branch 'origin/simple
On Tue, 21 Sep 2021 15:06:09 GMT, Hannes Wallnöfer wrote:
>> test/jdk/com/sun/net/httpserver/simpleserver/SecurityManagerTest.java line
>> 198:
>>
>>> 196:
>>> 197: static final DateTimeFormatter HTTP_DATE_FORMATTER =
>>> 198: DateTimeFormatter.ofPattern("EEE, dd MMM HH:mm
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 15:27:12 GMT, Daniel Fuchs wrote:
>> I just realized I commented on a test file, while the actual culprit is in
>> `FileServerHandler.java`. But I guess it applies to all usages of this class
>> and method.
>
> Hmm... When printing messages on the console don't we want a loc
On Tue, 21 Sep 2021 16:03:28 GMT, Hannes Wallnöfer wrote:
>> Hmm... When printing messages on the console don't we want a localized date?
>> Or are you referring to other usages of the date formatter? Worth double
>> checking in any case.
>
> The problem I was referring to was not about printi
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 16:18:54 GMT, Daniel Fuchs wrote:
>> The problem I was referring to was not about printing to the console. I
>> hadn't thought about that, I agree the default locale should be used there.
>> I was referring to `Last-modified` HTTP headers with a non-English date
>> value, e
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
16 matches
Mail list logo