RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Julia Boes
This change implements a simple web server that can be run on the command-line with `java -m jdk.httpserver`. This is facilitated by adding an entry point for the `jdk.httpserver` module, an implementation class whose main method is run when the above command is executed. This is the first such

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-14 Thread Masanori Yano
On Mon, 13 Sep 2021 13:18:10 GMT, Daniel Fuchs wrote: >> Masanori Yano has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commi

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v3]

2021-09-14 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request incrementally with

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Magnus Ihse Bursie
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Andrey Turbanov
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 13:19:17 GMT, Andrey Turbanov wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose mai

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Andrey Turbanov
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Jaikiran Pai
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Result: New Networking Group Member: Patrick Concannon

2021-09-14 Thread Daniel Fuchs
The vote for Patrick Concannon [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. --daniel [1] https://mail.openjdk.java.net/pipermail/net-dev/2021-August/016440.html

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Jaikiran Pai
On Tue, 14 Sep 2021 15:30:31 GMT, Jaikiran Pai wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main me

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Julia Boes
On Tue, 14 Sep 2021 15:42:06 GMT, Jaikiran Pai wrote: >> src/java.base/windows/classes/sun/net/www/content-types.properties line 30: >> >>> 28: application/octet-stream: \ >>> 29: description=Generic Binary Stream;\ >>> 30: file_extensions=.saveme,.dump,.hqx,.arc,.obj,.lib,.bin,.

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Julia Boes
On Tue, 14 Sep 2021 13:47:48 GMT, Andrey Turbanov wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose mai

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 16:07:21 GMT, Julia Boes wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line >> 288: >> >>> 286: } >>> 287: >>> 288: private static final Headers EMPTY = new UnmodifiableHeaders(new >>> Headers()); >> >> IDEA warns here: >>>Referenc

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Jim Laskey
On Tue, 14 Sep 2021 12:36:28 GMT, Jim Laskey wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Jim Laskey
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 12:38:19 GMT, Jim Laskey wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java >> line 128: >> >>> 126: * {@code headers} are the effective headers of the response. >>> The >>> 127: * response body bytes are a {@code UTF-8} encoded b

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 16:47:45 GMT, Daniel Fuchs wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main me

Re: RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value [v2]

2021-09-14 Thread Jonathan Dowland
On Fri, 10 Sep 2021 14:17:32 GMT, Daniel Fuchs wrote: >> Jonathan Dowland has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains one additional >> comm

Integrated: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value

2021-09-14 Thread Jonathan Dowland
On Fri, 16 Jul 2021 09:16:23 GMT, Jonathan Dowland wrote: > The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` uses > the IP address "1.1.1.1" as a value. I think at the time the address was > picked, the assumption was the address was not valid / not routable. Since > Ap

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Florent Guillaume
On Tue, 14 Sep 2021 15:56:53 GMT, Julia Boes wrote: >> I think you can ignore my comment above. I went and checked the >> `content-types.properties` in their current state for both unix and windows >> and they already have a separate `application/zip` which is mapped to >> `.zip`. So I think t

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Jaikiran Pai
On Wed, 15 Sep 2021 01:54:40 GMT, Florent Guillaume wrote: > FWIW `.z` is the extension of the old Unix `compress` program. Thank you Florent, I wasn't aware of that. - PR: https://git.openjdk.java.net/jdk/pull/5505