On Fri, 6 Aug 2021 19:50:48 GMT, Jonathan Dowland wrote:
>> The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java`
>> uses the IP address "1.1.1.1" as a value. I think at the time the address
>> was picked, the assumption was the address was not valid / not routable.
>> Since
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Thanks to those who reviewed this PR. Since I p
> 8273616: Fix trivial doc typos in the java.base module
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Use "ensure" instead of "insure"
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5475/files
- new: https
On Thu, 2 Sep 2021 14:24:24 GMT, Daniel Fuchs wrote:
>> Please review this change to the Unix implementations of
>> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel()
>> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a
>> check for the ST_KILLED state.)
>
>
> Please review this change to the Unix implementations of
> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel()
> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a
> check for the ST_KILLED state.)
Masanori Yano has updated the pull request with a new target
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
LGTM
-
Marked as
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by rriggs (R
On Mon, 13 Sep 2021 11:48:22 GMT, Masanori Yano wrote:
>> Please review this change to the Unix implementations of
>> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel()
>> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a
>> check for the ST_KILLED state.)
>
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by iris (Rev
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by lancea (R
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by jrose (Re
On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo wrote:
> 8273616: Fix trivial doc typos in the java.base module
This pull request has now been integrated.
Changeset: b4b12101
Author:Pavel Rappo
URL:
https://git.openjdk.java.net/jdk/commit/b4b121018d16e531f3a51ff75ae37fdc374d530b
Stats
12 matches
Mail list logo
