Re: RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream [v5]

2021-09-01 Thread Daniel Fuchs
On Tue, 31 Aug 2021 22:29:40 GMT, Ivan Šipka wrote: >> Ivan Šipka has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - 8263364: output >> - 8263364: removing surplus imports >> - 8263364: refactor >> - 826336

RFR: 8273243: Fix indentations in java.net.InetAddress methods

2021-09-01 Thread Aleksei Efimov
Hi, The fix changes indentations in the following `java.net.InetAddress` methods: - getAddressesFromNameService - getHostFromNameService It helps to improve code readability. Can't say the same about `getHostFromNameService` diffs shown in this PR. - Commit messages: - 8273243: Fi

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods

2021-09-01 Thread Brian Burkhalter
On Wed, 1 Sep 2021 16:53:50 GMT, Aleksei Efimov wrote: > Hi, > > The fix changes indentations in the following `java.net.InetAddress` methods: > - getAddressesFromNameService > - getHostFromNameService > > It helps to improve code readability. Can't say the same about > `getHostFromNameService

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods

2021-09-01 Thread Daniel Fuchs
On Wed, 1 Sep 2021 16:53:50 GMT, Aleksei Efimov wrote: > Hi, > > The fix changes indentations in the following `java.net.InetAddress` methods: > - getAddressesFromNameService > - getHostFromNameService > > It helps to improve code readability. Can't say the same about > `getHostFromNameService

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-01 Thread Aleksei Efimov
On Wed, 1 Sep 2021 17:08:24 GMT, Brian Burkhalter wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273243: looks -> looks like > > src/java.base/share/classes/java/net/InetAddress.java line 689: > >> 687:

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-01 Thread Aleksei Efimov
> Hi, > > The fix changes indentations in the following `java.net.InetAddress` methods: > - getAddressesFromNameService > - getHostFromNameService > > It helps to improve code readability. Can't say the same about > `getHostFromNameService` diffs shown in this PR. Aleksei Efimov has updated the