Re: RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order [v4]

2021-08-17 Thread Evan Whelan
> Hi all, > > Please review this fix for which corrects the order in which field values are > returned from the `HttpURLConnection.getHeaderFields` and > `URLConnection.getRequestProperties` methods. > > Currently, the implementation of these methods returns the values in reverse. > This does

Re: RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order [v4]

2021-08-17 Thread Daniel Fuchs
On Tue, 17 Aug 2021 08:52:36 GMT, Evan Whelan wrote: >> Hi all, >> >> Please review this fix for which corrects the order in which field values >> are returned from the `HttpURLConnection.getHeaderFields` and >> `URLConnection.getRequestProperties` methods. >> >> Currently, the implementation

Re: RFR: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders

2021-08-17 Thread Julia Boes
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes wrote: > This is a doc-only fix that improves the wording of the API doc of > `getRequestHeaders()`. The other changes are trivial cleanup. CSR https://bugs.openjdk.java.net/browse/JDK-8272565 - PR: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders [v2]

2021-08-17 Thread Julia Boes
> This is a doc-only fix that improves the wording of the API doc of > `getRequestHeaders()`. The other changes are trivial cleanup. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: small fix of tense - Changes: - all: h

Re: RFR: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders [v2]

2021-08-17 Thread Chris Hegarty
On Tue, 17 Aug 2021 10:55:02 GMT, Julia Boes wrote: >> This is a doc-only fix that improves the wording of the API doc of >> `getRequestHeaders()`. The other changes are trivial cleanup. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders [v2]

2021-08-17 Thread Daniel Fuchs
On Tue, 17 Aug 2021 10:55:02 GMT, Julia Boes wrote: >> This is a doc-only fix that improves the wording of the API doc of >> `getRequestHeaders()`. The other changes are trivial cleanup. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8253178: Replace LinkedList Impl in net.http.FilterFactory [v3]

2021-08-17 Thread Daniel Fuchs
On Mon, 19 Jul 2021 10:24:27 GMT, Sergei Ustimenko wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.FilterFactory class with an ArrayList. This issue relates to >> [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net.](https://bugs.openjdk.java.net/