Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

2021-07-01 Thread Alan Bateman
On Tue, 29 Jun 2021 16:06:52 GMT, Brian Burkhalter wrote: >> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 643: >> >>> 641: if (state == ChannelState.UNINITIALIZED) { >>> 642: SctpNet.close(fdVal); >>> 643: state = ChannelState.KI

Integrated: 8268960: com/sun/net/httpserver/Headers.java: Ensure mutators normalize keys and disallow null for keys and values

2021-07-01 Thread Julia Boes
On Fri, 18 Jun 2021 10:43:06 GMT, Julia Boes wrote: > `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the > following format: First character uppercase, all other characters lowercase, > for example `"foo" -> "Foo"`. This behaviour is not consistent across the > mutator metho

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

2021-07-01 Thread Brian Burkhalter
On Jul 1, 2021, at 1:17 AM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: It looks like you've changed some but not all cases. I realize ChannelState.UNINITIALIZED is not too interesting but further maintainers may wonder about it. I’m not seeing that I missed any cases. I don’t really

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

2021-07-01 Thread Brian Burkhalter
Oh I see now. Thanks. On Jul 1, 2021, at 8:56 AM, Alan Bateman mailto:alan.bate...@oracle.com>> wrote: I should have been clearer. Look at SctpServerChannelImpl.java L284 and SctpMultiChannelImpl.java L376. SctpNet.close(fdVal) added with the patch added them them before setting the state. Th

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

2021-07-01 Thread Alan Bateman
On 01/07/2021 16:47, Brian Burkhalter wrote: On Jul 1, 2021, at 1:17 AM, Alan Bateman > wrote: It looks like you've changed some but not all cases. I realize ChannelState.UNINITIALIZED is not too interesting but further maintainers may wonder about it. I’m n

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v4]

2021-07-01 Thread Brian Burkhalter
> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Fix

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v4]

2021-07-01 Thread Alan Bateman
On Thu, 1 Jul 2021 18:09:39 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with