On Tue, 25 May 2021 04:36:53 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix in the code sample in javadoc
> comment of `javax.net.ssl.SSLEngine` class?
>
> I've run `make docs-image` locally and the generated javadoc after this
> change looks fine.
This pull request
On Tue, 25 May 2021 04:36:53 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix in the code sample in javadoc
> comment of `javax.net.ssl.SSLEngine` class?
>
> I've run `make docs-image` locally and the generated javadoc after this
> change looks fine.
Thank you Xuelei
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
Сергей Цыпанов has refreshed the contents of this pull request, and previous
commits have been removed. The i
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
Сергей Цыпанов has updated the pull request with a new target base due to a
merge or a rebase. The incrementa
On Tue, 25 May 2021 18:03:51 GMT, Bradford Wetmore wrote:
> Simple typo fix. Somehow the trailing "u" got omitted, so the code won't
> parse when fed into the compiler.
>
> Resulting javadoc output now compiles.
This pull request has now been integrated.
Changeset: e751b7b1
Author:Bradfo
Simple typo fix. Somehow the trailing "u" got omitted, so the code won't parse
when fed into the compiler.
Resulting javadoc output now compiles.
-
Commit messages:
- Codereview Comments.
- 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters
javadoc
Changes:
On Tue, 25 May 2021 18:03:51 GMT, Bradford Wetmore wrote:
> Simple typo fix. Somehow the trailing "u" got omitted, so the code won't
> parse when fed into the compiler.
>
> Resulting javadoc output now compiles.
Looks good!
-
Marked as reviewed by coffeys (Reviewer).
PR: https:
Missed updating today's changeset with the new variable name.
It's a "one character fix."
-
Commit messages:
- 8267750: Incomplete fix for JDK-8267683
Changes: https://git.openjdk.java.net/jdk/pull/4196/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4196&range=00
Is
On Wed, 26 May 2021 01:12:14 GMT, Bradford Wetmore wrote:
> Missed updating today's changeset with the new variable name.
>
> It's a "one character fix."
Looks good.
-
Marked as reviewed by jnimeh (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4196
On Wed, 26 May 2021 01:12:14 GMT, Bradford Wetmore wrote:
> Missed updating today's changeset with the new variable name.
>
> It's a "one character fix."
This pull request has now been integrated.
Changeset: b33b8bc8
Author:Bradford Wetmore
URL:
https://git.openjdk.java.net/jdk/com
Hi all,
java/net/SctpSanity.java fails on some of our test machines due to Protocol not
supported.
The reason is that the test fails to detect all the cases when a machine
doesn't support SCTP.
The fix just follows what are done in [1][2][3] to detect unsupported paltforms
at the beginning.
T
12 matches
Mail list logo
