Re: RFR: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable [v5]

2021-04-07 Thread Julia Boes
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable > by wrapping it in an unmodifiable view. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebas

Re: RFR: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable [v3]

2021-04-07 Thread Julia Boes
On Tue, 6 Apr 2021 13:12:46 GMT, Julia Boes wrote: >> LGTM > > I included a null check in the constructor to account for null values of > `List`, which `Headers` allows. Fixed the indentation. > > Testing: Tier 1-3 all clear. It turns out I wasn't right in the last commit. The null check is no

Re: RFR: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable [v5]

2021-04-07 Thread Daniel Fuchs
On Wed, 7 Apr 2021 13:28:32 GMT, Julia Boes wrote: >> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable >> by wrapping it in an unmodifiable view. > > Julia Boes has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev e

Re: RFR: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable [v6]

2021-04-07 Thread Julia Boes
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable > by wrapping it in an unmodifiable view. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: assign unmodHeaders instead of original headers - Ch

Re: RFR: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable [v6]

2021-04-07 Thread Daniel Fuchs
On Wed, 7 Apr 2021 17:02:28 GMT, Julia Boes wrote: >> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable >> by wrapping it in an unmodifiable view. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > as