Hi Zheka,
On 05/04/2021 16:09, Zheka Kozlov wrote:
> Can we put at least new classes to some java.* package (SimpleFileServer,
> HttpHandlers, Request)? For example, java.net.httpserver.
The new classes extend/implement/build upon the existing abstractions in
jdk.httpserver, they have a clear AP
On Tue, 30 Mar 2021 11:30:48 GMT, Aleksei Efimov wrote:
> Current fix tries to tackle an issue with URL connection referencing
> non-existing Jar file entries:
> If an entry that doesn't exist is specified in an URL connection the
> underlying Jar file is still cached even if an exception is th
On 06/04/2021 11:25, Julia Boes wrote:
:
The new classes extend/implement/build upon the existing abstractions in
jdk.httpserver, they have a clear API relationship and cannot be easily
separated out. Indeed, separating them out would make things much more
confusing, given they are a logical exte
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebas
On Thu, 1 Apr 2021 14:08:47 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move constructor call in ExchangeImpl and fix indentation
>
> LGTM
I included a null check in the constructor to accou
On Tue, 6 Apr 2021 13:10:59 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev e
Hi,
Could I get the following small test fix reviewed please? The test is timing
out on Mac probably because it is running on a system with a proxy that is not
bypassed for loopback connections. The test already sets NO_PROXY explicitly
for one part of the test. It needs to do the equivalent fo
On Tue, 6 Apr 2021 15:17:53 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small test fix reviewed please? The test is timing
> out on Mac probably because it is running on a system with a proxy that is
> not bypassed for loopback connections. The test already sets NO_PROXY
>
On Tue, 6 Apr 2021 15:17:53 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small test fix reviewed please? The test is timing
> out on Mac probably because it is running on a system with a proxy that is
> not bypassed for loopback connections. The test already sets NO_PROXY
>
