Hi,
Could someone please review my changeset that fixes the "no comment" warnings
generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
Kind regards,
Patrick
-
Commit messages:
- 8252831: Correct "no comment" warnings in jdk.net module
Changes: https://git.openjdk.java.net/jd
On Tue, 2 Mar 2021 10:15:13 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset that fixes the "no comment" warnings
> generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
>
> Kind regards,
> Patrick
Marked as reviewed by chegar (Reviewer).
-
P
On Tue, 2 Mar 2021 10:15:13 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset that fixes the "no comment" warnings
> generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
>
> Kind regards,
> Patrick
LGTM
-
Marked as reviewed by vtewari (Commit
On Tue, 2 Mar 2021 10:15:13 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset that fixes the "no comment" warnings
> generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
>
> Kind regards,
> Patrick
LGTM
-
Marked as reviewed by dfuchs (Reviewe
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
>
On Wed, 24 Feb 2021 20:42:52 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a change that fixes "no comment" warnings generated by
> `javadoc -Xdoclint` for `java.base/java.net`
This pull request has now been integrated.
Changeset: 5f4bc0ac
Author:Daniel Fuchs
URL: https://gi
On Tue, 2 Mar 2021 12:43:27 GMT, Daniel Fuchs wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof SSLSocketImpl
On Tue, 2 Mar 2021 14:39:43 GMT, Vyom Tewari wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 569:
>>
>>> 567: SSLParameters paramaters = s.getSSLParameters();
>>> 568:
>>> paramaters.setEndpointIdentificationAlgo
On Tue, 2 Mar 2021 15:03:47 GMT, Daniel Fuchs wrote:
>> May be i am not sure, we may need this code change to review by security
>> expert. I am setting "SNIHostName" only if "isDefaultHostnameVerifier" is
>> true(If the HNV is the default from HttpsURLConnection) so there should not
>> be pro
On Tue, 2 Mar 2021 15:34:56 GMT, Vyom Tewari wrote:
>> Did you try to run the httpclient tests? They make use of the httpserver -
>> so they can also serve to test it - somewhat.
>> More generally - please run jdk_net/tier2 tests.
>
> i ran tests, it looks
> clean(https://github.com/vyommani/jd
On Tue, 2 Mar 2021 15:56:35 GMT, Daniel Fuchs wrote:
>> i ran tests, it looks
>> clean(https://github.com/vyommani/jdk/actions/runs/612949667)
>
> As far as I know this is only tier1 - so none of the network tests have been
> run.
I ran tier1 & tier2 tests locally on my linux vm, it was clear.
Please review some minor doc fixes, for issues found by _doccheck_.There
are two kinds of errors that are addressed.
1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph.
It is not a terminator, to mark the end of a paragraph, or a separator to mark
the boundary between
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
Hello,
Actually, in HTML was a separator, and in xhtml it should enclose
paragraphs. However I was under the impression Javadoc always used the
separator style (it would be strange to start the first sentence in Javadoc
with . Is this doccheck enforcing a new policy?
This officially Oracle gu
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
>
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instanceof SSLSocketImpl) {
> ((SSLSocketImpl)s).setHost(host);
>}
>
On Tue, 2 Mar 2021 20:17:25 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used List.of instead of Collections.singletonList
>
> src/java.base/share/classes/sun/net/www/protocol/https/HttpsC
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
> if (s instanceof SSLSocketImpl) {
> ((S
On Wed, 3 Mar 2021 04:38:47 GMT, Xue-Lei Andrew Fan wrote:
> > HttpsURLConnection, works with SunJSSE provider but does not work with
> > other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
> > name as follows
> > s = (SSLSocket)serverSocket;
> > if (s instanceof SSLSocket
22 matches
Mail list logo
