Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v3]

2021-02-05 Thread Jayashree S Kumar
> Issue > > https://bugs.openjdk.java.net/browse/JDK-8243376 > > Problem > > The scenario is: > - Some specified target hostname resolves to two IP addresses (always the > same address pair). > - The DNS resolved order of the two ip addresses changes (a usual > LoadBalancer type behavior).

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Patrick Concannon
> Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically configuring a system-wide factory for the `Socket`, > `ServerSocket`,

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Alan Bateman
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Daniel Fuchs
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v2]

2021-02-05 Thread Jayashree S Kumar
On Mon, 11 Jan 2021 15:04:03 GMT, Michael McMahon wrote: >> Jayashree S Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Incorporated changes suggested by Vyom in testcase > > Hi Jay, > Looking back to my original comment, I think I

Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v4]

2021-02-05 Thread Jayashree S Kumar
> Issue > > https://bugs.openjdk.java.net/browse/JDK-8243376 > > Problem > > The scenario is: > - Some specified target hostname resolves to two IP addresses (always the > same address pair). > - The DNS resolved order of the two ip addresses changes (a usual > LoadBalancer type behavior).

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Chris Hegarty
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Deprecate the socket impl factory mechanism [v4]

2021-02-05 Thread Patrick Concannon
> Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically configuring a system-wide factory for the `Socket`, > `ServerSocket`,

Re: RFR: 8235139: Deprecate the socket impl factory mechanism [v2]

2021-02-05 Thread Patrick Concannon
On Thu, 4 Feb 2021 15:20:31 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> co