Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v8]

2021-01-29 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request with a new target base due to a merge or a

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-29 Thread Clive Verghese
On Thu, 28 Jan 2021 19:04:29 GMT, Xue-Lei Andrew Fan wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. > > src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1702: > >> 1700: if (!conContext.isInboundClosed(

Re: RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order [v2]

2021-01-29 Thread Evan Whelan
On Thu, 28 Jan 2021 17:02:31 GMT, Daniel Fuchs wrote: >> Evan Whelan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> URLConnection doc fixes > > src/java.base/share/classes/java/net/URLConnection.java line 596: > >> 594: * correspo

Re: RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order [v2]

2021-01-29 Thread Evan Whelan
> Hi all, > > Please review this fix for which corrects the order in which field values are > returned from the `HttpURLConnection.getHeaderFields` and > `URLConnection.getRequestProperties` methods. > > Currently, the implementation of these methods returns the values in reverse. > This does

RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory

2021-01-29 Thread Daniel Fuchs
DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that allows to globally replace the default DatagramSocket/MulticastSocket implementation provided by the JDK. This was provided a way in early JDK releases to replace the system wide implementation. It has been mostly obsol

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v2]

2021-01-29 Thread Daniel Fuchs
> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that > allows to globally replace the default DatagramSocket/MulticastSocket > implementation provided by the JDK. This was provided as a way in early JDK > releases to replace the system wide implementation. It has been m

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v2]

2021-01-29 Thread Alan Bateman
On Fri, 29 Jan 2021 12:31:04 GMT, Daniel Fuchs wrote: >> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that >> allows to globally replace the default DatagramSocket/MulticastSocket >> implementation provided by the JDK. This was provided as a way in early JDK >> relea

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v2]

2021-01-29 Thread Daniel Fuchs
On Fri, 29 Jan 2021 18:02:25 GMT, Alan Bateman wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket >> without using DatagramSocketImplFactory > >

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v3]

2021-01-29 Thread Daniel Fuchs
> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that > allows to globally replace the default DatagramSocket/MulticastSocket > implementation provided by the JDK. This was provided as a way in early JDK > releases to replace the system wide implementation. It has been m

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v4]

2021-01-29 Thread Daniel Fuchs
> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that > allows to globally replace the default DatagramSocket/MulticastSocket > implementation provided by the JDK. This was provided as a way in early JDK > releases to replace the system wide implementation. It has been m

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v5]

2021-01-29 Thread Daniel Fuchs
> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that > allows to globally replace the default DatagramSocket/MulticastSocket > implementation provided by the JDK. This was provided as a way in early JDK > releases to replace the system wide implementation. It has been m

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory

2021-01-29 Thread Daniel Fuchs
On Fri, 29 Jan 2021 11:34:07 GMT, Daniel Fuchs wrote: > DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that > allows to globally replace the default DatagramSocket/MulticastSocket > implementation provided by the JDK. This was provided as a way in early JDK > releases