Re: RFR: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens [v3]

2020-12-10 Thread Chris Hegarty
On Sat, 5 Dec 2020 04:54:27 GMT, Yasumasa Suenaga wrote: >> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when >> the stream reaches EOF. However IOE handler returns without closing. >> >> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think >> `Bod

Integrated: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further informati

2020-12-10 Thread Daniel Fuchs
On Wed, 9 Dec 2020 15:37:42 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a changeset that fixes the infrequent (but annoying) test > failures > caused by unexpected ConnectionException "Connection timed out: no further > information" > which have been observed to occur on some platform

Re: RFR: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens [v3]

2020-12-10 Thread Daniel Fuchs
On Thu, 10 Dec 2020 09:35:05 GMT, Chris Hegarty wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Throw UIOE when stream throws IOE > > test/jdk/java/net/httpclient/StreamCloseTest.java line 37: > >> 35: * @com

Re: RFR: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens [v4]

2020-12-10 Thread Yasumasa Suenaga
> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when > the stream reaches EOF. However IOE handler returns without closing. > > I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think > `BodyPublishers.ofFile()`has same problem because it also use > `St

Re: RFR: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens [v3]

2020-12-10 Thread Yasumasa Suenaga
On Thu, 10 Dec 2020 10:13:01 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/StreamCloseTest.java line 37: >> >>> 35: * @compile ../../../com/sun/net/httpserver/FileServerHandler.java >>> 36: * @build jdk.test.lib.net.SimpleSSLContext >>> 37: * @build LightWeightHttpServer >> >> It

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v5]

2020-12-10 Thread Yumin Qi
> Hi, Please review > Windows mapping for file into memory could not happen to reserved memory. > In mapping CDS archive we first reserve enough memory then before mapping, > release them. For cds archive and using class space, need split the whole > space into two, that is, release the whole

Withdrawn: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"

2020-12-10 Thread Yumin Qi
On Mon, 7 Dec 2020 05:01:27 GMT, Yumin Qi wrote: > Hi, Please review > Windows mapping for file into memory could not happen to reserved memory. > In mapping CDS archive we first reserve enough memory then before mapping, > release them. For cds archive and using class space, need split the w

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v5]

2020-12-10 Thread Yumin Qi
On Tue, 8 Dec 2020 06:12:36 GMT, Yumin Qi wrote: >> Changes requested by iklam (Reviewer). > > Please check 03. 02 is generated when merge with most current and remote head > not updated correctly. After set remote head correct, 03 is regenerated and > is correct one for review. Thanks This br