Hi Kartik,
I ran your patch through our test suite and it came back fine so I’ve created a
JIRA issue to track your fix: https://bugs.openjdk.java.net/browse/JDK-8257401.
Now that you have a bug ID for your changes, can you update the commit message
for the PR to use the format `bug id : messa
Hi!
Kindly review this patch to replace switch statements with switch expressions
(where it makes sense) in the http client modules. The rationale is to improve
readability of the code.
Regards,
Kartik
-
Commit messages:
- Use switch expressions in jdk.internal.net.http and java.ne
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has refreshed the contents of this pull request, and previous
commits
Hi Patrick,
Thank you for testing the patch and creating the issue. I have updated the
commit message and the PR title as well.
Regards,
Kartik
On Mon, Nov 30, 2020 at 6:14 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi Kartik,
>
> I ran your patch through our test suite and it
On Sat, 21 Nov 2020 11:45:42 GMT, Kartik Ohri
wrote:
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Just a question.
Do we hav
