Re: Use switch expressions in jdk.internal.net.http and java.net.http

Hi Kartik, > On 21 Nov 2020, at 12:01, Kartik Ohri wrote: > > Hi! > I would like to submit this patch https://github.com/openjdk/jdk/pull/1364 > with the rationale to improve the > readability of the code. Can someone please take a look at it and crea

what happened to JDK-8187450 (JNI local refs exceeds capacity warning in NetworkInterface::getAll)

Hi folks, We have some interest in fixing (and then backporting) JDK-8187450. Looking at the bug, there's a patch posted in a comment but no webrev or RFR, etc. I've had a look at applying the patch to current HEAD and it only requires mino

Re: RFR: 8255675: Typo in java.net.HttpURLConnection

On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV wrote: > 8255675: Typo in java.net.HttpURLConnection Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1250

Re: RFR: 8255675: Typo in java.net.HttpURLConnection

On Mon, 23 Nov 2020 10:44:12 GMT, Chris Hegarty wrote: >> 8255675: Typo in java.net.HttpURLConnection > > Marked as reviewed by chegar (Reviewer). What is the effect if this change is integrated as is (from the master branch)? The normal procedure is to merge from a separate branch. --

Re: [11u] RFR: 8232854: URLClassLoader.close() doesn't close cached JAR file on Windows when load() fails

Hi, On 3/1/20, Alex Kashchenko wrote: > Hi, > > Please review the fix to JDK-8232854 for 11u: > > Jira issue: https://bugs.openjdk.java.net/browse/JDK-8232854 > > Webrev: http://cr.openjdk.java.net/~akasko/jdk11u/8232854/webrev.00/ > > Patch is implemented based on a test code included with the J

Re: RFR: 8255675: Typo in java.net.HttpURLConnection

On Mon, 23 Nov 2020 11:01:35 GMT, Michael McMahon wrote: > What is the effect if this change is integrated as is (from the master > branch)? The normal procedure is to merge from a separate branch. @anupamdev20 note the bot comment above, pushing from your master branch will diverge it. You ca

Integrated: 8255675: Typo in java.net.HttpURLConnection

On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV wrote: > 8255675: Typo in java.net.HttpURLConnection This pull request has now been integrated. Changeset: 895cc4f0 Author:ANUPAM DEV <73814169+anupamde...@users.noreply.github.com> Committer: Julia Boes URL: https://git.openjdk.java.net/

Re: Use switch expressions in jdk.internal.net.http and java.net.http

Hi Kartik, Thanks for submitting the patch. Once you’ve run the tier2 tests, I’d be happy to sponsor it for you. -Patrick > On 23 Nov 2020, at 09:09, Chris Hegarty wrote: > > Hi Kartik, > >> On 21 Nov 2020, at 12:01, Kartik Ohri wrote: >> >> Hi! >> I would like to submit this patch https: