On Fri, 30 Oct 2020 15:59:57 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8255584: fixed ordering of realm and username in name
>
> Marked as reviewed by dfuchs (Reviewer).
> /csr needed
Hi Joshua,
On 31/10/2020 00:15, Joshua Anderson wrote:
Is this checking and reviewing necessary? Should I have written a
background task that reviews all InputStream’s created by the HttpClient
and calls .close() if the user forgets. The intent here is to free up
these resources. Without track
Hi,
Could someone please review my fix for JDK-8253005: 'Add `@throws IOException`
in javadoc for `HttpEchange.sendResponseHeaders`' ?
The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
unspecified in its javadoc. This fix adds an `@throws IOException` to its
specifica
On Mon, 2 Nov 2020 17:14:28 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecifi
On Mon, 2 Nov 2020 17:14:28 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecifi
On Mon, 2 Nov 2020 17:46:27 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Could someone please review my fix for JDK-8253005: 'Add `@throws
>> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>>
>> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
>> unspeci
