Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v2]

2020-10-29 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253473: 'Javadoc clean > up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator ' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.H

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253473: 'Javadoc clean > up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator ' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.H

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Patrick Concannon
On Wed, 28 Oct 2020 14:27:38 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8253473: Updated the @param for HttpPrincipal::getName; fixed @code tags > > src/jdk.httpserver/share/classes/com/

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Patrick Concannon
On Wed, 28 Oct 2020 14:44:55 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpPrincipal.java >> line 100: >> >>> 98: /** >>> 99: * Returns a hashcode for this {@code HttpPrincipal}. This is >>> calculated >>> 100: * as (getUsername()+getReal

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Daniel Fuchs
On Thu, 29 Oct 2020 11:01:59 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253473: 'Javadoc clean >> up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator ' ? >> >> This fix is set of formatting changes intended to clean up the

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Daniel Fuchs
On Thu, 29 Oct 2020 11:01:59 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253473: 'Javadoc clean >> up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator ' ? >> >> This fix is set of formatting changes intended to clean up the

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Patrick Concannon
On Thu, 29 Oct 2020 11:07:35 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8253473: Updated the @param for HttpPrincipal::getName; fixed @code tags > > src/jdk.httpserver/share/classes/com/

Re: RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

2020-10-29 Thread Daniel Fuchs
On Thu, 29 Oct 2020 12:07:59 GMT, Patrick Concannon wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpPrincipal.java >> line 58: >> >>> 56: * otherwise. >>> 57: * >>> 58: * @param another the object to compare this instance of {@code >>> HttpPrincipal} again