Re: RFR: 8245194: Unix domain socket channel implementation [v35]

2020-10-24 Thread Alan Bateman
On Thu, 22 Oct 2020 08:14:31 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects

2020-10-24 Thread Phil Race
On Thu, 22 Oct 2020 20:46:15 GMT, Сергей Цыпанов wrote: > As discussed in https://github.com/openjdk/jdk/pull/510 there is never a > reason to explicitly instantiate any instance of `Atomic*` class with its > default value, i.e. `new AtomicInteger(0)` could be replaced with `new > AtomicInteg

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-24 Thread Marcono1234
On Fri, 23 Oct 2020 17:50:51 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this small patch? >> >> according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in >> MLSx response have the following format: >>>time-val = 14DIGIT [ "." 1*DIGIT ] >>> >>>