Re: RFR: 8245194: Unix domain socket channel implementation [v24]

2020-10-15 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v23]

2020-10-15 Thread Michael McMahon
On Wed, 14 Oct 2020 18:37:57 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix white space error > > src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 717: > >> 715:

Re: RFR: 8245194: Unix domain socket channel implementation [v24]

2020-10-15 Thread Daniel Fuchs
On Thu, 15 Oct 2020 08:01:27 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Request: mechanism for making HttpRequest.Builder from HttpRequest

2020-10-15 Thread Craig Andrews
Java's HttpClient relies on the builder pattern to produce immutable objects on which actual operations are done. However, it currently lacks a way to convert those working objects back to builders in order to mutate them. For example, I'd like to take a java.net.http.HttpRequest and change it

Re: Request: mechanism for making HttpRequest.Builder from HttpRequest

2020-10-15 Thread Chris Hegarty
Hi Craig, > On 15 Oct 2020, at 17:22, Craig Andrews wrote: > > Java's HttpClient relies on the builder pattern to produce immutable objects > on which actual operations are done. However, it currently lacks a way to > convert those working objects back to builders in order to mutate them. I a