Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v3]

2020-10-13 Thread Chris Hegarty
On Mon, 12 Oct 2020 13:50:30 GMT, Daniel Fuchs wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> n

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v3]

2020-10-13 Thread Michael McMahon
On Mon, 12 Oct 2020 13:50:30 GMT, Daniel Fuchs wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> n

Integrated: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-13 Thread Daniel Fuchs
On Thu, 8 Oct 2020 11:22:09 GMT, Daniel Fuchs wrote: > Hi, > > This is a fix that upgrades the old HTTP and HTTPS legacy stack to use > virtual-thread friendly locking instead of > synchronized monitors. > Most of the changes are mechanical - but there are still a numbers of subtle > non-mecha

Re: RFR: 8254704: Add missing @since tag to BodyPublishers::concat

2020-10-13 Thread Chris Hegarty
On Tue, 13 Oct 2020 15:22:07 GMT, Daniel Fuchs wrote: > Please review a trivial change that adds a missing `@since 16` tag to the API > documentation of the new > `BodyPublishers::concat` method. I missed that in my changes that was > integrated yesterday - and that was unfortunately > missed i

RFR: 8254704: Add missing @since tag to BodyPublishers::concat

2020-10-13 Thread Daniel Fuchs
Please review a trivial change that adds a missing `@since 16` tag to the API documentation of the new `BodyPublishers::concat` method. I missed that in my changes that was integrated yesterday - and that was unfortunately missed in the review and CSR as well. - Commit messages: -

Integrated: 8254704: Add missing @since tag to BodyPublishers::concat

2020-10-13 Thread Daniel Fuchs
On Tue, 13 Oct 2020 15:22:07 GMT, Daniel Fuchs wrote: > Please review a trivial change that adds a missing `@since 16` tag to the API > documentation of the new > `BodyPublishers::concat` method. I missed that in my changes that was > integrated yesterday - and that was unfortunately > missed i

Re: RFR: 8245194: Unix domain socket channel implementation [v14]

2020-10-13 Thread Michael McMahon
On Mon, 12 Oct 2020 11:02:12 GMT, Michael McMahon wrote: >> Thanks again Alan. Assume where there is no comment from me below that >> suggestions are accepted: >> I will push an update based on these changes soon. >> >> Michael. >> >>> _Mailing list message from [Alan Bateman](mailto:alan.bate

Re: RFR: 8245194: Unix domain socket channel implementation [v19]

2020-10-13 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v20]

2020-10-13 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use