RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Conor Cleary
This patch replaces a LinkedList data structure used in the net.http.Http2Connection class with an ArrayList. This issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in java.net](https://bugs.openjdk.java.net/browse/JDK-8246048). Some justifications for this change are as follows:

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Aleksey Shipilev
On Wed, 30 Sep 2020 10:22:11 GMT, Conor Cleary wrote: > This patch replaces a LinkedList data structure used in the > net.http.Http2Connection class with an ArrayList. This > issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in > java.net](https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 08:22:35 GMT, Aleksey Shipilev wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/bro

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Conor Cleary
On Thu, 1 Oct 2020 09:43:46 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java >> line 703: >> >>> 701: if (initialCause == null) this.cause = t; >>> 702: client2.deleteConnection(this); >>> 703: List> c = new ArrayList

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Pavel Rappo
On Thu, 1 Oct 2020 10:31:58 GMT, Conor Cleary wrote: >> Good point Aleksey. I guess that the original intent was to avoid >> `ConcurrentModificationException`. However I see that >> `streams` is a `ConcurrentHashMap` now. So maybe we could dispense of the >> copy: >> `private final Map> str

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v3]

2020-10-01 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 10:38:43 GMT, Pavel Rappo wrote: >> Taking a look at this presently > > Although Aleksey's proposal does not change the behavior, it raises a > question (to be explored separately): can a > stream be added to that map while `Http2Connection.shutdown` is in progress? > If this

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Patrick Concannon
On Wed, 30 Sep 2020 10:31:29 GMT, Michael McMahon wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Patrick Concannon
On Wed, 30 Sep 2020 10:21:22 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional com

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Michael McMahon
On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 14:27:10 GMT, Michael McMahon wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional c