On Mon, 7 Sep 2020 13:54:52 GMT, Daniel Fuchs wrote:
> Continuing the review with a PR...
>
> 8252374: Add a new factory method to concatenate a sequence
> of BodyPublisher instances into a single publisher.
> https://bugs.openjdk.java.net/browse/JDK-8252374
>
>
> Draft CSR:
> https:/
On Tue, 8 Sep 2020 16:22:15 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint
> warnings in jdk.net.httpserver’ ?
>
> This fix addresses the warnings generated by `javadoc -Xdoclint` due to
> missing/incomplete API documentatio
Hi,
Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean up
in Authenticator and BasicAuthenicator'
?
This fix is set of formatting changes intended to clean up the javadoc of the
following classes :
`com.sun.net.httpserver.Authenticator`
`com.sun.net.httpserver.Authent
On Tue, 22 Sep 2020 15:13:27 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean
> up in Authenticator and BasicAuthenicator'
> ?
> This fix is set of formatting changes intended to clean up the javadoc of the
> following classe
On Tue, 22 Sep 2020 15:56:57 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8253053: fixed typos; added tags
>
> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Authenticator.java
>
> Hi,
>
> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean
> up in Authenticator and BasicAuthenicator'
> ?
> This fix is set of formatting changes intended to clean up the javadoc of the
> following classes :
>
> `com.sun.net.httpserver.Authenticator`
> `com.sun.net
On Tue, 22 Sep 2020 16:20:17 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean
>> up in Authenticator and BasicAuthenicator'
>> ?
>> This fix is set of formatting changes intended to clean up the javadoc of
>> the following
Hi Kim,
Sorry for the delay.
This patch removes a redundant string copy in NetworkInterface.c to avoid
string-truncation
warning. Other warnings we talked before, which are unable to completely fix in
different version
of gcc, I have to use pragma to suppress them as a workaround.
This pat
