Re: RFR[8251496]: ‘Fix doclint warnings in jdk.net.httpserver’

2020-09-09 Thread Daniel Fuchs
On 08/09/2020 21:02, Roger Riggs wrote: And will need to be updated as a new PR under git. PR: https://git.openjdk.java.net/jdk/pull/81 best regards, -- daniel

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v2]

2020-09-09 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint > warnings in jdk.net.httpserver’ ? > > This fix addresses the warnings generated by `javadoc -Xdoclint` due to > missing/incomplete API documentation for > several classes within `jdk.net.httpserver`. > CSR: h

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v3]

2020-09-09 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint > warnings in jdk.net.httpserver’ ? > > This fix addresses the warnings generated by `javadoc -Xdoclint` due to > missing/incomplete API documentation for > several classes within `jdk.net.httpserver`. > Kind r

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v3]

2020-09-09 Thread Patrick Concannon
On Tue, 8 Sep 2020 16:34:12 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8251496: reworded abstract cstr comments; removed unnecessary punctuation > > src/jdk.httpserver/share/classes/com/

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v3]

2020-09-09 Thread Roger Riggs
On Wed, 9 Sep 2020 12:16:44 GMT, Patrick Concannon wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java >> line 30: >> >>> 28: import java.net.InetSocketAddress; >>> 29: >>> 30: //BEGIN_TIGER_EXCLUDE >> >> I don't have the context here - but if we're removing

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v3]

2020-09-09 Thread Roger Riggs
On Wed, 9 Sep 2020 12:14:28 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint >> warnings in jdk.net.httpserver’ ? >> >> This fix addresses the warnings generated by `javadoc -Xdoclint` due to >> missing/incomplete API docum

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v3]

2020-09-09 Thread Chris Hegarty
On Wed, 9 Sep 2020 13:29:05 GMT, Roger Riggs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8251496: reworded abstract cstr comments; removed unnecessary punctuation > > The @param and @return lines that star

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v3]

2020-09-09 Thread Roger Riggs
On Wed, 9 Sep 2020 12:14:28 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint >> warnings in jdk.net.httpserver’ ? >> >> This fix addresses the warnings generated by `javadoc -Xdoclint` due to >> missing/incomplete API docum

Re: RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v2]

2020-09-09 Thread Chris Hegarty
On Wed, 9 Sep 2020 08:50:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint >> warnings in jdk.net.httpserver’ ? >> >> This fix addresses the warnings generated by `javadoc -Xdoclint` due to >> missing/incomplete API docum

Re: Thread safety problem in java.net.ProxySelector

2020-09-09 Thread Chris Hegarty
Seems like a bug. Can you please file an issue for it. Thanks, -Chris. > On 2 Sep 2020, at 14:16, David Lloyd wrote: > > The default proxy selector field in java.net.ProxySelector is > essentially a global variable with no thread safety measures taken to > ensure that accesses are valid. Anecd