Looks good to me - and trivial.
Thanks,
David
On 7/09/2020 2:22 pm, Christoph Langer wrote:
The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.
There should not be a comma character (",")
On Mon, 7 Sep 2020 07:25:41 GMT, David Holmes wrote:
>> The format for SAP copyrights in OpenJDK headers should be like:
>> Copyright (c) SAP SE. All rights reserved.
>> or
>> Copyright (c) , SAP SE. All rights reserved.
>>
>> There should not be a comma character (",") before "SAP SE".
>>
>>
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote:
> The format for SAP copyrights in OpenJDK headers should be like:
> Copyright (c) SAP SE. All rights reserved.
> or
> Copyright (c) , SAP SE. All rights reserved.
>
> There should not be a comma character (",") before "SAP SE".
>
> Thi
On Mon, 7 Sep 2020 07:28:36 GMT, Christoph Langer wrote:
>>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
>>> [nio-dev](mailto:nio-...@openjdk.java.net):_
>>> Looks good to me - and trivial.
>>>
>>> Thanks,
>>> David
>>>
>>> On 7/09/2020 2:22 pm, Christoph Langer
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote:
> The format for SAP copyrights in OpenJDK headers should be like:
> Copyright (c) SAP SE. All rights reserved.
> or
> Copyright (c) , SAP SE. All rights reserved.
>
> There should not be a comma character (",") before "SAP SE".
>
> Thi
On Mon, 7 Sep 2020 07:27:39 GMT, Christoph Langer wrote:
>> Marked as reviewed by dholmes (Reviewer).
>
>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
>> [nio-dev](mailto:nio-...@openjdk.java.net):_
>> Looks good to me - and trivial.
>>
>> Thanks,
>> David
>>
>>
On Sun, 6 Sep 2020 11:21:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 08:33:17 GMT, Chris Hegarty wrote:
>> Jaikiran Pai has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new commi
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Mon, 7 Sep 2020 09:15:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 09:18:31 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 09:28:39 GMT, Alan Bateman wrote:
> I see Jaikiran has used "/integrate" but I don't think the review is complete
> yet. The change may be trivial but it's
> really important to give others a chance to comment if they wish.
Sorry, I'm new this whole flow. I saw the message fr
On Mon, 7 Sep 2020 09:24:06 GMT, Alan Bateman wrote:
> Given that the test update is significant then it makes me wonder if we
> should just move to TestNG while we're at it.
> It would avoid needing to add expectIllegalStateException.
I wasn't sure if it was OK to do it as part of this change.
On Mon, 7 Sep 2020 09:15:13 GMT, Chris Hegarty wrote:
>> Jaikiran Pai has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new commi
On Mon, 7 Sep 2020 09:31:02 GMT, Jaikiran Pai wrote:
>> I see Jaikiran has used "/integrate" but I don't think the review is
>> complete yet. The change may be trivial but it's
>> really important to give others a chance to comment if they wish.
>
>> I see Jaikiran has used "/integrate" but I do
On Mon, 7 Sep 2020 09:35:16 GMT, Jaikiran Pai wrote:
>>> I see Jaikiran has used "/integrate" but I don't think the review is
>>> complete yet. The change may be trivial but it's
>>> really important to give others a chance to comment if they wish.
>>
>> Sorry, I'm new this whole flow. I saw th
* Kim Barrett:
> And strlen is not even necessarily the best solution, as it likely
> introduces an additional otherwise unnecessary string traversal. For
> example, getFlags could be changed to reject an overly long ifname,
> without using strlen, thusly:
>
> strncpy(if2.ifr_name, ifname, siz
On Mon, 7 Sep 2020 09:37:23 GMT, Chris Hegarty wrote:
>> Slightly OT - but I think this `/integrate` command shouldn't actually be in
>> the hands of the contributor and instead
>> should be decided and issued by "committers" or "sponsors". I don't really
>> see how the contributor/author can
>
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Mon, 7 Sep 2020 09:37:23 GMT, Chris Hegarty wrote:
> @jaikiran No need to be sorry, you are following the process as it is
> outlined. Please go ahead with the suggestion to
> update the test to use TestNG. The current state of the PR should not affect
> updates. BTW AFAIK, you should not ne
On Mon, 7 Sep 2020 11:04:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 11:04:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Mon, 7 Sep 2020 11:24:18 GMT, Chris Hegarty wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Convert to TestNG test case
>
> test/jdk/java/net/URLConnection/RequestProperties.java line 90:
>
>> 88: try {
Continuing this review as a PR on github with the comments below incorporated.
I expect there will be a few more
iterations before integrating.
On 06/09/2020 19:47, Alan Bateman wrote:
> On 26/08/2020 15:24, Michael McMahon wrote:
>>
>> As I mentioned the other day, I wasn't able to use the sugge
On Mon, 7 Sep 2020 11:47:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 11:47:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Mon, 7 Sep 2020 12:35:50 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use new TestNG Assert#assertThrows API
>
> I think this version looks much better. A few nits with naming/style but not
On Mon, 7 Sep 2020 12:41:49 GMT, Daniel Fuchs wrote:
>> I think this version looks much better. A few nits with naming/style but not
>> worth spending time on.
>
> Hi Jaikiran,
>
> I'll sponsor this for you when it is ready to integrate but I'd like to send
> it to our test system first.
>
>
Continuing the review with a PR...
8252374: Add a new factory method to concatenate a sequence
of BodyPublisher instances into a single publisher.
https://bugs.openjdk.java.net/browse/JDK-8252374
Draft CSR:
https://bugs.openjdk.java.net/browse/JDK-8252382
-
Commit messages
Hi Kim:
Thanks for the discussion, this makes more sense to me now.
> Kim Barrett on 06 September 2020 19:35 wrote:
>
> Can you be (very) specific about this. Do all of these changes cause gcc10
> to warn? Or
> do only some of them. If only some, specifically which ones? I have a
> conjec
On Mon, 7 Sep 2020 13:48:17 GMT, Jaikiran Pai wrote:
>> Hi Jaikiran,
>>
>> I'll sponsor this for you when it is ready to integrate but I'd like to send
>> it to our test system first.
>>
>> best regards,
>> -- daniel
>
> Thank you everyone for the reviews and thank you Daniel for sponsoring. I
32 matches
Mail list logo
