Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such as 'strncpy' that may either truncate the copied string or leave the destination unchanged. This patch fixed stringop-truncati

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Eric, The changes to NetworkInterface.c look good to me. best regards, -- daniel On 01/09/2020 09:01, Eric Liu wrote: Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Eric, Kim, On 01/09/2020 10:46, Kim Barrett wrote: he changes being made to getIndex and getFlags (NetworkInterface.c) are modifying lines that were changed very recently to deal with such warnings from gcc10. I'm worried that these new changes will re-trigger warnings from gcc10 (though thi

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Daniel, Kim, Thanks for your review. > Kim Barrett on Tue Sep 1 09:46:26 UTC 2020 > > Changes look good, subject to that caveat. I think these changes conform > better to the documented description of the warning than did the recent > NetworkInterface.c change mentioned above, so I’m hopeful

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

On 2020-09-01 11:46, Kim Barrett wrote: On Sep 1, 2020, at 4:01 AM, Eric Liu wrote: Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such as 'strncpy' that may either truncate t