Hi Nick,
Looks good to me. But while you're at it, could you make
the `ok` and `requests` fields volatile?
best regards,
-- daniel
On 14/08/2020 04:42, Nick Gasson wrote:
Hi,
Bug: http://cr.openjdk.java.net/~ngasson/8251517/webrev.0/
Webrev: https://bugs.openjdk.java.net/browse/JDK-8251517
Hi Daniel,
On 08/14/20 17:27 pm, Daniel Fuchs wrote:
>
> Looks good to me. But while you're at it, could you make
> the `ok` and `requests` fields volatile?
>
Sure, this one ok to push?
https://cr.openjdk.java.net/~ngasson/8251517/webrev.1/
--
Thanks,
Nick
On 14/08/2020 11:44, Nick Gasson wrote:
Hi Daniel,
On 08/14/20 17:27 pm, Daniel Fuchs wrote:
Looks good to me. But while you're at it, could you make
the `ok` and `requests` fields volatile?
Sure, this one ok to push?
https://cr.openjdk.java.net/~ngasson/8251517/webrev.1/
Looks fine!
be
Hi all,
I'm Evan and I've just recently joined the Java Platform Group here in Oracle
so this is my first time getting to interact with the OpenJDK Community.
This is a request to review my fix for
https://bugs.openjdk.java.net/browse/JDK-8133686
The webrev for this fix can be found a
Hi all,
Requesting some reviewers for a patch concerning JDK-8246047 'Replace
LinkedList impl in net.http.websocket.BuilderImpl'. This patch replaces
LinkedList data structures used in the net.http.websocket BuilderImpl
class with ArrayLists. In particular, the 'headers' and 'subprotocols'
Co
Hi Conor,
Thanks for addressing this technical debt.
I don't think this is correct. You transformed the immutable
copy at line 137 into a shallow clone, since now both copies
share the same mutable list.
I suggest to revert the changes at lines:
66,67,144 and 145.
(and that will be much simpl
Hi,
After discussion with Chris & Alan I have slightly reworded
the API documentation, and ensured the MultiExchange is only
weakly referenced from the MinimalFuture to avoid the risk of
pinning the exchange in memory after it is no longer needed.
Also I added a trivial test for the case where t
Thanks for the suggestion Daniel, looks much nicer without the casting
in the immutableCopy function as well!
I made a new patch with those reverted changes and it looks much nicer
and still behaves as expected.
webrev:
http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8246047/webrevs
> On 14 Aug 2020, at 16:48, Conor Cleary wrote:
>
> Thanks for the suggestion Daniel, looks much nicer without the casting in the
> immutableCopy function as well!
>
> I made a new patch with those reverted changes and it looks much nicer and
> still behaves as expected.
>
> webrev:
> htt
On 14/08/2020 16:43, Daniel Fuchs wrote:
Hi,
After discussion with Chris & Alan I have slightly reworded
the API documentation, and ensured the MultiExchange is only
weakly referenced from the MinimalFuture to avoid the risk of
pinning the exchange in memory after it is no longer needed.
Als
On 14/08/2020 16:48, Conor Cleary wrote:
Thanks for the suggestion Daniel, looks much nicer without the casting
in the immutableCopy function as well!
I made a new patch with those reverted changes and it looks much nicer
and still behaves as expected.
webrev:
http://cr.openjdk.java.net/~cc
11 matches
Mail list logo
