Hi,
Could someone please review my fix for JDK-8240901 — ‘Add a test to check that
large datagrams are sent/received on the network correctly’ ?
The tests `java/net/DatagramSocket/SendReceiveMaxSize.java` and
`java/net/DatagramSocket/SendReceiveMaxSize.java` have been updated to check
(on all
Hi Patrick,
I thought I had mentioned it before, but the DatagramChannel test
looks wrong: if I am not mistaken the assertTrue check that compare
the two buffers will always succeed, even if the data in the two
buffers is different. It only requires that the two buffers are
filled to their limit:
Hi Daniel,
Thanks for pointing this out.
Please find the corrections in the updated webrev below.
http://cr.openjdk.java.net/~pconcannon/8240901/webrevs/webrev.01/
Kind regards,
Patrick
> On 11 Aug 2020, at 16:41, Daniel Fuchs wrote:
>
> Hi Patrick,
>
> I thought I had mentioned it before,