Re: 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request

Thanks for suggesting this course of action Michael! This flushed out two additional bugs in our stack, which I believe are probably at the root of some of the rare intermittent failures we have been observing in the Throwing* tests: - SocketTube: I found an issue where the scheduler might not

Re: RFR[8246164]: ‘SendDatagramToBadAddress.java and ChangingAddress.java should be changed to explicitly require the new DatagramSocket implementation’

Thanks Vyom! -Patrick > On 30 Jul 2020, at 05:41, Vyom Tiwari wrote: > > Hi Patrick, > Changes looks ok to me. > Thanks, > Vyom > > On Wed, Jul 29, 2020 at 9:45 PM Patrick Concannon > mailto:patrick.concan...@oracle.com>> wrote: > Hi, > > Could someone please review my fix for JDK-8246164 —

Re: 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request

Hi Daniel, Good to see that produced useful results. I think it would be a good idea to separate the two additional fixes if possible. That would certainly make back-porting a lot easier. Thanks, Michael. On 31/07/2020 10:46, Daniel Fuchs wrote: Thanks for suggesting this course of action Mich

8229822: ThrowingPushPromises tests sometimes fail due to EOF

Hi, Please find below a fix for: 8229822: ThrowingPushPromises tests sometimes fail due to EOF https://bugs.openjdk.java.net/browse/JDK-8229822 While trying to write a good test for JDK-8245462 I stumbled on two issues - which I believe are at the root of the ThrowingPushPromises failures: -

Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

On 28/07/2020 15:03, Nikola Grcevski wrote: Hi Alan, Thanks again for testing this change. I dug deep into the issue yesterday and got some answers from the Windows Networking team. The issue is that the flag TCP_INITIAL_RTO_NO_SYN_RETRANSMISSIONS, which we passed in to completely eliminat

RFR[8250889]: 'Disable testing SendReceiveMaxSize with preferIPv4Stack=true on the old impl until JDK-8250886 is fixed'

Hi, Could someone please review my fix for JDK-8250889 — 'Disable testing SendReceiveMaxSize with preferIPv4Stack=true on the old impl until JDK-8250886 is fixed’ ? The `test java/net/DatagramSocket/SendReceiveMaxSize` is currently failing when run with `-Djdk.net.usePlainDatagramSocketImpl` a

Re: RFR[8250889]: 'Disable testing SendReceiveMaxSize with preferIPv4Stack=true on the old impl until JDK-8250886 is fixed'

Looks good to me Patrick. Thanks for jumping on this. best regards, -- daniel On 31/07/2020 18:42, Patrick Concannon wrote: Hi, Could someone please review my fix for JDK-8250889 — 'Disable testing SendReceiveMaxSize with preferIPv4Stack=true on the old impl until JDK-8250886 is fixed’ ?