On 23/07/2020 02:52, Nikola Grcevski wrote:
Hi Alex,
Yes, you are right about that. I didn't think about extending the check to more
than 127.0.0.1.
The existing macro was only testing for 127.0.0.1 in both IP4 and IP6 modes, so
if the consensus
is that we want to extend to all of the poss
Hi Charlie,
Thanks for finding and fixing this!
I have fixed many such failures in the logging tests in
the past.
Your changes look good to me.
Reviewed.
Do you need a sponsor for this?
best regards,
-- daniel
On 22/07/2020 20:38, Charlie Gracie wrote:
Hi,
I believe there was a subtle tim
That's a great idea Alan. If we are OK to merge this improvement with support
for 127.0.0.1 only,
I'll follow up with another patch for the full range of the loopback adapter
and some tests
for the macro in all 3 modes.
Thanks.
Nikola
-Original Message-
From: Alan Bateman
Sent: July
Hi Daniel,
Thanks for the review!
Yep, I will need a sponsor for this.
Cheers,
Charlie Gracie
On 2020-07-23, 8:38 AM, "Daniel Fuchs" wrote:
> Hi Charlie,
>
> Thanks for finding and fixing this!
> I have fixed many such failures in the logging tests in
> the past.
>
> Your changes look good to
On 23/07/2020 15:21, Charlie Gracie wrote:
Hi Daniel,
Thanks for the review!
Yep, I will need a sponsor for this.
OK - I will import your changes and test them.
If successful - I'll push them for you.
I'll report on this list. I might not get
on on this until next week though.
best regards,
Hi,
More testing revealed that some other tests of the same family
kept on failing intermittently, though my changes to
PendingOperation.java should have fixed them.
So here is a broader fix - which seems to have fixed the issue.
But as a consequence - I am no longer planning to push it to
15 a
Hi Daniel,
This looks like good work. A couple of points/questions:
- commented code in RequestPublishers.java can be deleted presumably
- RequestPublishers.IterablePublisher :: computeLength(). What is the
reason for returning -1
here instead of the computed length.
- why does Stream.reg
Hi Michael,
On 23/07/2020 18:48, Michael McMahon wrote:
Hi Daniel,
This looks like good work. A couple of points/questions:
- commented code in RequestPublishers.java can be deleted presumably
Yes - good point.
- RequestPublishers.IterablePublisher :: computeLength(). What is the
reason fo
Hello,
Please review the replacement of default constructors in various
abstract classes in java.net with explicit constructors:
webrev: http://cr.openjdk.java.net/~darcy/8250244.0/
CSR: https://bugs.openjdk.java.net/browse/JDK-8250245
(This is part of a larger effort to remove defaul
looks ok to me.
Vyom
On Fri, Jul 24, 2020 at 6:05 AM Joe Darcy wrote:
> Hello,
>
> Please review the replacement of default constructors in various
> abstract classes in java.net with explicit constructors:
>
> webrev: http://cr.openjdk.java.net/~darcy/8250244.0/
> CSR: https://bugs.op
10 matches
Mail list logo
