Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-16 Thread Alan Bateman
On 16/07/2020 05:37, Bernd Eckenfels wrote: Hello Nikola, Can you explain why timeouts play a role here at all? Normally when connecting to a non existing socket it should immediately respond with a TCP RST and that should not cause a retry or delay. Nikola mentioned that he is in contact wi

Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-16 Thread Alan Bateman
On 16/07/2020 01:02, Nikola Grcevski wrote: : Please find the webrev with this improvement here: http://cr.openjdk.java.net/~adityam/nikola/fast_connect_loopback/ Just a few comments on the first iteration. Can we move the function prototype to the Windows net_util_md.h? That would avoid ne

RE: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-16 Thread Nikola Grcevski
Hi Bernd and Alan, I had initially the same question about the socket connects, especially since it works so much better on Unix’s. The reason why Windows can’t change the implementation is app compatibility. They have implemented an ECN (Explicit Congestion Notification) related mitigation in

IPV6 literal string handling in tests

2020-07-16 Thread Mat Carter
Hello net-dev I have been investigating an intermittent error with the following tests in jdk11u and identified fixes that could be back-ported:   tests/jdk/sun/net/www/protocal/httponly.java tests/jdk/sun/net/www/protocal/nocache.java   The error was a malformed string being passed to the

RE: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-16 Thread Nikola Grcevski
Thanks for reviewing the patch Alan. I applied your suggestions in this new webrev here: http://cr.openjdk.java.net/~adityam/nikola/fast_connect_loopback_1/ I renamed the macro to IN6_IS_ADDR_MAPPED_IP4_LOOPBACK, following how IN6_IS_ADDR_ANY is named in the same file. I hope the new name works