Hi Daniel,
Thanks for documenting the system properties. It looks good to me.
NIT: You might want to update the copyright's last modification year to 2020
Best Regards,
Aleksei
On 06/07/2020 16:39, Daniel Fuchs wrote:
Hi,
Please find below a doc only change to document two
JDK specific JNDI/
Looks ok to me.
-Chris.
> On 6 Jul 2020, at 16:39, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a doc only change to document two
> JDK specific JNDI/LDAP timeout properties:
>
> 8248865: Document JNDI/LDAP timeout properties
> https://bugs.openjdk.java.net/browse/JDK-8248865
>
> webrev
You should document what the behavior is if an invalid string value is
set (ex: not an integer).
--Sean
On 7/7/20 7:11 AM, Aleks Efimov wrote:
Hi Daniel,
Thanks for documenting the system properties. It looks good to me.
NIT: You might want to update the copyright's last modification year to
Hi Sean,
Good point.
It appears it throws a java.lang.NumberFormatException which is not
documented as being thrown by any InitialContext constructors or its
subclasses, nor by `addToEnvironment`.
I believe this is a more general problem - and I would beg to tackle
that in a followup issue if y
On 7/7/20 9:02 AM, Daniel Fuchs wrote:
Hi Sean,
Good point.
It appears it throws a java.lang.NumberFormatException which is not
documented as being thrown by any InitialContext constructors or its
subclasses, nor by `addToEnvironment`.
Ugh, ok.
I believe this is a more general problem - and
On 07/07/2020 14:08, Sean Mullan wrote:
I believe this is a more general problem - and I would beg to tackle
that in a followup issue if you don't mind.
Ok.
For the record I have logged
https://bugs.openjdk.java.net/browse/JDK-8248909
best regards,
-- daniel
Hi Vyom,
I imported your latest patch and ran it on our test system, and I noticed the
following error on Windows:
[2020-07-07T11:09:20,621Z]
T:\workspace\open\test\jdk\java\net\Socket\libNativeThread.c(54) : error C2220:
the following warning is treated as an error
[2020-07-07T11:09:20,621Z]
I was curious if there has been any thought to allowing accessing to other
certificate stores in Windows besides the "Trusted Root Certification
Authorities" and the "Personal" ones. It seems like web servers omitting
intermediate certificates in the certificate chain is pretty common. Browser
Hi Patrick,
Thanks for testing, please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev1.0/index.html). I fixed
the windows build issue.
Thanks,
Vyom
On Tue, Jul 7, 2020 at 11:49 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi Vyom,
>
> I imported your l
