Hi Vyom,
What is the purpose of calling NativeThread.close?
Is that just to clean up and make the server thread terminate?
If so there should be better ways to do that.
When does the test succeed?
Looking at SocketAcceptInterruptTest it looks like the test
will succeed if it manages to send the
Hi Daniel,
Thanks for review, please find my answers below.
1-> What is the purpose of calling NativeThread.close?
To close the thread which is waiting in SocketAccept, I wrote a test in
such a way that the server thread will wait infinitely in socket accept and
there will not be any incoming so
On 24/06/2020 12:14, Vyom Tiwari wrote:
3-> Looking at SocketAcceptInterruptTest it looks like the test
will succeed if it manages to send the signal - and that's it.
Is it really a measure of success?
No, I explained in question 2.
So basically you rely on the test infrastructure having
regi
let me refactor the test, i will try to incorporate your suggestion.
Vyom
On Wed, Jun 24, 2020 at 5:21 PM Daniel Fuchs
wrote:
> On 24/06/2020 12:14, Vyom Tiwari wrote:
> > 3-> Looking at SocketAcceptInterruptTest it looks like the test
> > will succeed if it manages to send the signal - and tha
