RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

2020-06-12 Thread Rahul
Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter. The fix updates sun.net.httpserver.ExchangeImpl to use thread safe DateTimeFormatter for response headers, this replaces DateFormat that was using ThreadLocal

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

2020-06-12 Thread Alan Bateman
On 12/06/2020 15:56, Rahul wrote: Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter. The fix updates sun.net.httpserver.ExchangeImpl to use thread safe DateTimeFormatter for response headers, this replaces DateForma

RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

2020-06-12 Thread Rahul
Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter. The fix updates sun.net.httpserver.ExchangeImpl to use thread safe DateTimeFormatter for response headers, this replaces DateFormat that was using ThreadLocal

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

2020-06-12 Thread Rahul Yadav
Hi Alan, Thank you for the feedback. I have updated the webrev.  http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html - rahul On 12/06/2020 16:57, Alan Bateman wrote: On 12/06/2020 15:56, Rahul wrote: Hello, Request to have my fix reviewed for the issue: JDK-8245307 : Update Exc

Re: RFR 8245307 : Update ExchangeImpl to use thread safe DateTimeFormatter

2020-06-12 Thread Alan Bateman
On 12/06/2020 17:55, Rahul Yadav wrote: Hi Alan, Thank you for the feedback. I have updated the webrev. http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html Thank for the update, this looks good. Minor nit is that we typically use order the modifiers so that it's "static final" rather