RFR[8246143]: 'UnreferencedXXX tests fail when run with --illegal-access=deny'

2020-06-11 Thread Conor Cleary
Hi, Could someone please take a look at my webrev for JDK-8246143: 'UnreferencedXXX tests fail when run with --illegal-access=deny'? This patch addresses test failures with test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java and test/jdk/java/net/MulticastSocket/UnreferencedMult

Re: RFR[8246143]: 'UnreferencedXXX tests fail when run with --illegal-access=deny'

2020-06-11 Thread Daniel Fuchs
Looks good to me Conor! best regards, -- daniel On 11/06/2020 10:35, Conor Cleary wrote: Hi, Could someone please take a look at my webrev for JDK-8246143: 'UnreferencedXXX tests fail when run with --illegal-access=deny'? This patch addresses test failures with test/jdk/java/net/DatagramS

Re: RFR[8246143]: 'UnreferencedXXX tests fail when run with --illegal-access=deny'

2020-06-11 Thread Alan Bateman
On 11/06/2020 10:35, Conor Cleary wrote: Hi, Could someone please take a look at my webrev for JDK-8246143: 'UnreferencedXXX tests fail when run with --illegal-access=deny'? This patch addresses test failures with test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java and test/jdk

java.net.BindException doesn't include host info even when jdk.includeInExceptions is set to hostInfo

2020-06-11 Thread Jaikiran Pai
The security.properties file in Java 11 (and later) have a new configuration: # The categories are: # #  hostInfo - IOExceptions thrown by java.net.Socket and the socket types in the # java.nio.channels package will contain enhanced exception # message information # # The p

Re: java.net.BindException doesn't include host info even when jdk.includeInExceptions is set to hostInfo

2020-06-11 Thread Alan Bateman
On 11/06/2020 14:31, Jaikiran Pai wrote: The security.properties file in Java 11 (and later) have a new configuration: # The categories are: # #  hostInfo - IOExceptions thrown by java.net.Socket and the socket types in the # java.nio.channels package will contain enhanced exception

Re: java.net.BindException doesn't include host info even when jdk.includeInExceptions is set to hostInfo

2020-06-11 Thread Jaikiran Pai
Hello Alan, On 11/06/20 7:18 pm, Alan Bateman wrote: > On 11/06/2020 14:31, Jaikiran Pai wrote: >> The security.properties file in Java 11 (and later) have a new >> configuration: >> >> # The categories are: >> # >> #  hostInfo - IOExceptions thrown by java.net.Socket and the socket >> types in th

Re: java.net.BindException doesn't include host info even when jdk.includeInExceptions is set to hostInfo

2020-06-11 Thread Alan Bateman
On 11/06/2020 14:59, Jaikiran Pai wrote: : Is this a valid use case to have this part of the JDK code enhanced to include the additional host/port information (of course when that security property is enabled)? Yes but there there are always security concerns with including too much information

Re: java.net.BindException doesn't include host info even when jdk.includeInExceptions is set to hostInfo

2020-06-11 Thread Jaikiran Pai
On 11/06/20 7:40 pm, Alan Bateman wrote: > On 11/06/2020 14:59, Jaikiran Pai wrote: >> : >> Is this a valid use case to have this part of the JDK code enhanced to >> include the additional host/port information (of course when that >> security property is enabled)? >> > Yes but there there are al

Re: java.net.BindException doesn't include host info even when jdk.includeInExceptions is set to hostInfo

2020-06-11 Thread Jaikiran Pai
On 11/06/20 7:47 pm, Jaikiran Pai wrote: > > I'll open a JBS enhancement in a short while to have this part enhanced > to report the additional details only when the specific security > property is enabled. I've created https://bugs.openjdk.java.net/browse/JDK-8247413 to track this. -Jaikiran