Re: RFR: 8244958: preferIPv4Stack and preferIPv6Addresses do not affect addresses returned by HostsFileNameService

2020-05-25 Thread Aleks Efimov
Hi Alan, Daniel, Thank you for looking into this change. I've cleaned-up the fix and the test according to your comments. Modified fix can be viewed here: http://cr.openjdk.java.net/~aefimov/8244958/01 Kind Regards, Aleksei On 24/05/2020 08:12, Alan Bateman wrote: On 22/05/2020 16:45, Aleks

Re: RFR: 8244958: preferIPv4Stack and preferIPv6Addresses do not affect addresses returned by HostsFileNameService

2020-05-25 Thread Vyom Tiwari
Hi Aleksei, Latest webrev(01) looks good to me, one minor comment "PREFER_IPV4_STACK" variable naming convention is not consistent with other similar variables(preferIPv6Address) in InetAddress.java. Thanks, Vyom On Mon, May 25, 2020 at 4:18 PM Aleks Efimov wrote: > Hi Alan, Daniel, > > Thank

Re: RFR: 8244958: preferIPv4Stack and preferIPv6Addresses do not affect addresses returned by HostsFileNameService

2020-05-25 Thread Aleks Efimov
Hi Vyom, Thanks for reviewing it. I'm ok with stepping aside of general naming convention to maintain the compatibility with the naming in InetAddress code:    InetAddress.HostsFileNameService.PREFER_IPV4_STACK renamed to InetAddress.HostsFileNameService.preferIPv4Stack Webrev was updated at