Hi Vladimir, Patrick,
The new tests look very good. There's just a small issue I noticed.
It's present in all the new tests - here is an example on
AsynchronousSocketChannelNAPITest.java:
This code in @BeforeTest:
63 try (var s = AsynchronousSocketChannel.open()) {
64
On 14/05/2020 14:09, Andrew Dinn wrote:
:
I was unaware that this was a spec requirement for static libs. Can you
point me at any discussion that explains why this is required and what
the function might be expected to do? or even tell me when it was added
to the spec? The macro appears to implem
Hi Alan,
On 12/05/2020 19:57, Alan Bateman wrote:
> Looks okay to me.
I am glad to hear that and also to see this fixed quickly (thanks Bob
for posting the patch). I'd like to see it backported to jdk11u (via
jdk14u, of course) if possible in order to allow stock jdk14u/11u to be
used to build Gr
> On May 14, 2020, at 9:09 AM, Andrew Dinn wrote:
>
> Hi Alan,
>
> On 12/05/2020 19:57, Alan Bateman wrote:
>> Looks okay to me.
>
> I am glad to hear that and also to see this fixed quickly (thanks Bob
> for posting the patch). I'd like to see it backported to jdk11u (via
> jdk14u, of course)
On 13/05/2020 15:07, Chris Hegarty wrote:
On 8 May 2020, at 16:46, Daniel Fuchs wrote:
Hi,
Please find a fix for:
8244031: HttpClient should have more tests for HEAD requests
https://bugs.openjdk.java.net/browse/JDK-8244031
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8244031/webrev.0
Thanks Daniel
I would proceed with the push if there are no further comments.
On 13/05/2020, 12:39, "Daniel Fuchs" wrote:
Hi Rahul,
That looks good to me thanks!
I am still teetering on whether we should also have altered the
specification of WSHandshakeException, and
I updated the CSR wordings slightly to make it easier to read. If no
objections, I plan to move it to "Proposed" today.
https://bugs.openjdk.java.net/browse/JDK-8244858
Best Regards,
Sandhya
-Original Message-
From: net-dev On Behalf Of Viswanathan,
Sandhya
Sent: Tuesday, May 12, 202
Thanks a lot Daniel! I missed these double checks.
Updated webrev may be reviewed as
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.14
I use only one condition for the 'if' in the 'startup' method while kernel
should support or not both types of sockets together.
Thanks, Vla
