Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-13 Thread Patrick Concannon
Great, thanks Valdimir Also, it might be worthwhile adding a check to ensure the NAPI ID remains consistent across multiple send/receives read/writes, and to test similar socket types e.g.  AsynchronousSocketChannel For example: http://cr.openjdk.java.net/~pconcannon/8243099/webrevs/webrev.0

Re: RFR 8244652: Add test for non utf-8 response handling by websocket client

2020-05-13 Thread Daniel Fuchs
Hi Rahul, That looks good to me thanks! I am still teetering on whether we should also have altered the specification of WSHandshakeException, and explicitly changed the signature of WSHandshakeException::getResponse to return an HttpResponse instead of an HttpResponse. On the one hand - our im

Re: 8244031: HttpClient should have more tests for HEAD requests

2020-05-13 Thread Chris Hegarty
> On 8 May 2020, at 16:46, Daniel Fuchs wrote: > > Hi, > > Please find a fix for: > > 8244031: HttpClient should have more tests for HEAD requests > https://bugs.openjdk.java.net/browse/JDK-8244031 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webrev_8244031/webrev.00/ Seems like a compr

RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-13 Thread Ivanov, Vladimir A
Thanks a lot. The updated webrev available as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.13/ Thanks, Vladimir -Original Message- From: Patrick Concannon Sent: Wednesday, May 13, 2020 4:16 AM To: Ivanov, Vladimir A ; Alan Bateman ; OpenJDK Network Dev list Subjec