RFR[8243507]: 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'

2020-04-28 Thread Patrick Concannon
Hi, Could someone please review my fix for JDK-8243507 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'? Currently, the DatagramSocket constructor `DatagramSocket(SocketAddress bindaddr)` doesn't specify what happens if passed a SocketAddress su

Re: RFR[8243507]: 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'

2020-04-28 Thread Daniel Fuchs
Hi Patrick, Looks good to me. I realize we haven't specified what happens if the `laddr` is null. Are you planning to fix that in a separate changeset or tag it to this one? Maybe we should unify the description of the `port` parameter in the two constructors: 327 * @param port port