Updated patch after considering the impact of returning default parameters on
the http client.
TLS versions earlier limited to 1.2 and above by client, now will support all
versions(wrt the scenarios for this bug).
Issue: https://bugs.openjdk.java.net/browse/JDK-8239595
Issue: https:
> On 8 Apr 2020, at 10:13, Rahul wrote:
>
> Updated patch after considering the impact of returning default parameters on
> the http client.
> TLS versions earlier limited to 1.2 and above by client, now will support all
> versions(wrt the scenarios for this bug).
>
>Issue: https://bugs
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
I took the liberty of additionally fixing a couple of parameters' names,
a typo, and `@exception` tags for checked exceptions that were neither thrown
nor imported.
Hi Pavel,
Not a review ...
On 8/04/2020 9:50 pm, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
I took the liberty of additionally fixing a couple of parameters' names,
a typo, and `@excep
Hi Pavel,
On 08/04/2020 13:56, David Holmes wrote:
and `@exception` tags for checked exceptions that were neither thrown
nor imported
Hopefully that's only on internal classes.
It might be prudent to separate this out in a different
changeset. It's not always obvious where an exception
is thro
The security changes look fine to me.
--Sean
On 4/8/20 7:50 AM, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
I took the liberty of additionally fixing a couple of parameters' names,
a ty
On 08/04/2020 14:07, Daniel Fuchs wrote:
Hi Pavel,
On 08/04/2020 13:56, David Holmes wrote:
and `@exception` tags for checked exceptions that were neither thrown
nor imported
Hopefully that's only on internal classes.
From a quick scan, the changes are to internal classes and a few
non-publi
Hey David,
Where exactly? In the files affected by this changeset? If so, then we will
introduce inconsistency. Otherwise it's a huge change. From what I can see there
are some 250 occurrences of `@exception` in
src/java.base/share/classes/com/sun/{crypto, security}
and some 7,300 in src.
Person
Why assume something that sophisticated where it can be adequately explained by
a simpler thing? :) I bet it was an IDE inspection.
-Pavel
> On 8 Apr 2020, at 14:14, Alan Bateman wrote:
>
> On 08/04/2020 14:07, Daniel Fuchs wrote:
>> Hi Pavel,
>>
>> On 08/04/2020 13:56, David Holmes wrote:
>>>
On 08/04/2020 12:50, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http://cr.openjdk.java.net/~prappo/8242366/webrev.00/
Hi Pavel,
That looks good to me.
WRT to the @exception changes I'll leave that responsibility
to Sean ;-)
best regards,
Good work Rahul!
I am not sure whether that deserves a CSR (probably not) but we may
want to create some release note to explain that the HttpClient is no
longer overriding the default protocols selected by the SSLContext.
So HTTP 1.1 over TLSv1.1 might now get negotiated where previously
an han
> On Apr 8, 2020, at 6:57 PM, Pavel Rappo wrote:
>
> Why assume something that sophisticated where it can be adequately explained
> by
> a simpler thing? :) I bet it was an IDE inspection.
>
> -Pavel
Yes, it was IDE inspection in java.base, it looked like the best way to start
contributing
If your new patch addresses a similar type of problem, please send it in reply
to this email,
so that I could merge it with the existing patch. Let's try to minimize process
overhead if possible.
> On 8 Apr 2020, at 17:35, Vipin Sharma wrote:
>
>
>
>> On Apr 8, 2020, at 6:57 PM, Pavel Rappo
Hi Pavel,
On 8/04/2020 11:23 pm, Pavel Rappo wrote:
Hey David,
Where exactly? In the files affected by this changeset? If so, then we will
introduce inconsistency. Otherwise it's a huge change. From what I can see there
are some 250 occurrences of `@exception` in
src/java.base/share/classes/co
14 matches
Mail list logo
