Re: [15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

2020-03-29 Thread Alan Bateman
On 29/03/2020 05:44, Ivan Gerasimov wrote: Hello! The fix follows up on JDK-8241727 [1]. This is a javadoc/comments only fix in the net and nio areas. The changes are to remove redundant empty lines, correct indentation, or otherwise restore harmony. Would you please help review this rather

Re: [15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

2020-03-29 Thread Pavel Rappo
Ivan, 1. ByteBuffered has an awkwardly looking top-level doc comment markup/formatting. The "payload" begins on the same line as the /** marker. Also, the tag is weirdly placed. Since you have fixed similar issues already (URLConnection), you could probably do the same here. Your call. 2. I kno

Re: [15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

2020-03-29 Thread Ivan Gerasimov
Thank you Alan and Pavel! My apologies for a wrong link in the initial request. Here's the new webrev with the changes suggested by Pavel: http://cr.openjdk.java.net/~igerasim/8241760/01/webrev/ With kind regards, Ivan G. On 3/29/20 2:43 PM, Pavel Rappo wrote: Ivan, 1. ByteBuffered has an