Re: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-27 Thread Alan Bateman
On 26/03/2020 20:35, Daniel Fuchs wrote: Hi Alan. On 26/03/2020 17:29, Alan Bateman wrote: NetworkConfiguration.isTestable - is the hardcoded check for "awdl" needed? I don't think I've seen it with non-link local address so I can't tell if it is needed. I'm It might no longer be needed,

Re: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-27 Thread Daniel Fuchs
Hi Alan, On 27/03/2020 09:06, Alan Bateman wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8241336/webrev.02/ This mostly looks good except that I'd prefer if the the code in assertNotSame be moved into testSendNoReceive (it was an oversight in the original test that testSendNoReceive didn't

Re: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-27 Thread Chris Hegarty
> On 27 Mar 2020, at 09:30, Daniel Fuchs wrote: > > Hi Alan, > > On 27/03/2020 09:06, Alan Bateman wrote: >>> http://cr.openjdk.java.net/~dfuchs/webrev_8241336/webrev.02/ >> This mostly looks good except that I'd prefer if the the code in >> assertNotSame be moved into testSendNoReceive (it w

Re: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

2020-03-27 Thread Alan Bateman
On 27/03/2020 09:30, Daniel Fuchs wrote: Hi Alan, On 27/03/2020 09:06, Alan Bateman wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8241336/webrev.02/ This mostly looks good except that I'd prefer if the the code in assertNotSame be moved into testSendNoReceive (it was an oversight in the

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-27 Thread Michael McMahon
Hi Xuelei, I have some concerns about these bugs also, though not exactly the same as yours: The "jdk.tls.client.protocols" system property is not part of the HTTP client API. So, it's not clear to me why the HTTP client is expected to enforce it. It is equally possible for any code using SS

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-27 Thread Chris Hegarty
Xuelei, Before commenting further on the interaction of the HTTP Client with various contorted configurations, I would like to get a better understanding of the `jdk.tls.client.protocols` property. Is there a specification or other documentation describing `jdk.tls.client.protocols` ? It is

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-27 Thread Xuelei Fan
On 3/27/2020 5:52 AM, Chris Hegarty wrote: Xuelei, Before commenting further on the interaction of the HTTP Client with various contorted configurations, I would like to get a better understanding of the `jdk.tls.client.protocols` property. Is there a specification or other documentation desc

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-27 Thread Chris Hegarty
Thank you Xuelei, this very helpful. Sorry, but I am going to ask just a few more clarifying questions to make sure that we’re on the same page. > On 27 Mar 2020, at 16:23, Xuelei Fan wrote: > > On 3/27/2020 5:52 AM, Chris Hegarty wrote: >> Xuelei, >> Before commenting further on the interacti

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-27 Thread Xuelei Fan
On 3/27/2020 10:36 AM, Chris Hegarty wrote: Thank you Xuelei, this very helpful. Sorry, but I am going to ask just a few more clarifying questions to make sure that we’re on the same page. On 27 Mar 2020, at 16:23, Xuelei Fan wrote: On 3/27/2020 5:52 AM, Chris Hegarty wrote: Xuelei, Before

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-27 Thread Chris Hegarty
Thank you for these clarifications. We will now consider how these affect, if at all, the HTTP Client. -Chris. > On 27 Mar 2020, at 17:47, Xuelei Fan wrote: > > On 3/27/2020 10:36 AM, Chris Hegarty wrote: >> Thank you Xuelei, this very helpful. >> Sorry, but I am going to ask just a few more c

Java 14 - Change in InetSocketAddress.toString() behaviour seems to be causing issues

2020-03-27 Thread Jaikiran Pai
There's an issue raised in Quarkus repo[1], where Apache Kafka (embedded) no longer starts on Java 14. From what I can see the root cause is this[2]. JDK-8225499[3] changed the implementation (and even the javadoc) of the InetSocketAddress.toString() which now reads[4]: "... If the address is un