8241443: Problem list some java.net tests failing with NoRouteToHostException on macOS with special network configuration

2020-03-23 Thread Daniel Fuchs
Hi, Please find below a changeset for: 8241443: Problem list some java.net tests failing with NoRouteToHostException on macOS with special network configuration We are observing some net/nio tests failing on some of our mac machines. While we investigate the issue we would lik

Re: 8241443: Problem list some java.net tests failing with NoRouteToHostException on macOS with special network configuration

2020-03-23 Thread Alan Bateman
The approach seems okay until the test infrastructure is fixed to ignore the problematic interfaces. Would you mind listing the DatagramChannel tests with the other DatagramChannel tests that are already excluded so they aren't in random order. -Alan On 23/03/2020 13:22, Daniel Fuchs wrote:

Re: 8241443: Problem list some java.net tests failing with NoRouteToHostException on macOS with special network configuration

2020-03-23 Thread Daniel Fuchs
On 23/03/2020 13:32, Alan Bateman wrote: The approach seems okay until the test infrastructure is fixed to ignore the problematic interfaces. Would you mind listing the DatagramChannel tests with the other DatagramChannel tests that are already excluded so they aren't in random order. Thanks

RFR[8241072]: 'Reimplement Legacy DatagramSocket API'

2020-03-23 Thread Patrick Concannon
This is a request for review for the implementation changes for JEP 373: 'Reimplement Legacy DatagramSocket API' [1]. A CSR has also been created [2]. The implementation of JEP 373 can be viewed on the JDK-8230211-branch in the sandbox [3]. A link to the webrev with the cumulated changes is

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

2020-03-23 Thread Julia Boes
Hi Daniel, We should try to call Path::toFile first - whether there is a security manager or not. In the case where that succeeds, we can use new FileInputStream(), otherwise, we use Files.newInputStream. It's unfortunate that new FileInputStream() and Files.newInputStream() use different sets

Re: RFR[8241072]: 'Reimplement Legacy DatagramSocket API'

2020-03-23 Thread Alan Bateman
On 23/03/2020 16:37, Patrick Concannon wrote: This is a request for review for the implementation changes for JEP 373: 'Reimplement Legacy DatagramSocket API' [1]. A CSR has also been created [2]. The implementation of JEP 373 can be viewed on the JDK-8230211-branch in the sandbox [3]. A li

Re: RFR: 8235459: HttpRequest.BodyPublishers#ofFile(Path) assumes the default file system

2020-03-23 Thread Amy Lu
On 3/24/20 1:51 AM, Julia Boes wrote: Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8235459/webrev.03/ Hi, Julia Just a minor comment on the test usage of /othervm/java.security.policy=FilePublisherPermsTest3.policy -Djava.security.manager As jtreg tag-spec [1] suggested:   The